Merge pull request #375 from PowerShell/rkeithhill/column-breakpoint-support

Enable column breakpoints.

Author: daviwil

src/PowerShellEditorServices.Protocol/Client/DebugAdapterClientBase.cs

@@ -40,7 +40,8 @@ protected override Task OnConnect()
                 InitializeRequest.Type,
                 new InitializeRequestArguments
                 {
-                    LinesStartAt1 = true
+                    LinesStartAt1 = true,
+                    ColumnsStartAt1 = true
                 });
         }
     }

src/PowerShellEditorServices.Protocol/DebugAdapter/InitializeRequest.cs

@@ -20,6 +20,8 @@ public class InitializeRequestArguments
 
         public bool LinesStartAt1 { get; set; }
 
+        public bool ColumnsStartAt1 { get; set; }
+
         public string PathFormat { get; set; }
 
         public bool SourceMaps { get; set; }
@@ -30,31 +32,31 @@ public class InitializeRequestArguments
     public class InitializeResponseBody
     {
         /// <summary>
-        /// Gets or sets a boolean value that determines whether the debug adapter 
+        /// Gets or sets a boolean value that determines whether the debug adapter
         /// supports the configurationDoneRequest.
         /// </summary>
         public bool SupportsConfigurationDoneRequest { get; set; }
 
         /// <summary>
-        /// Gets or sets a boolean value that determines whether the debug adapter 
+        /// Gets or sets a boolean value that determines whether the debug adapter
         /// supports functionBreakpoints.
         /// </summary>
         public bool SupportsFunctionBreakpoints { get; set; }
 
         /// <summary>
-        /// Gets or sets a boolean value that determines whether the debug adapter 
+        /// Gets or sets a boolean value that determines whether the debug adapter
         /// supports conditionalBreakpoints.
         /// </summary>
         public bool SupportsConditionalBreakpoints { get; set; }
 
         /// <summary>
-        /// Gets or sets a boolean value that determines whether the debug adapter 
+        /// Gets or sets a boolean value that determines whether the debug adapter
         /// supports breakpoints that break execution after a specified number of hits.
         /// </summary>
         public bool SupportsHitConditionalBreakpoints { get; set; }
 
         /// <summary>
-        /// Gets or sets a boolean value that determines whether the debug adapter 
+        /// Gets or sets a boolean value that determines whether the debug adapter
         /// supports a (side effect free) evaluate request for data hovers.
         /// </summary>
         public bool SupportsEvaluateForHovers { get; set; }

src/PowerShellEditorServices/Debugging/BreakpointDetails.cs

@@ -45,9 +45,9 @@ private BreakpointDetails()
         /// <param name="hitCondition"></param>
         /// <returns></returns>
         public static BreakpointDetails Create(
-            string source, 
-            int line, 
-            int? column = null, 
+            string source,
+            int line,
+            int? column = null,
             string condition = null,
             string hitCondition = null)
         {
@@ -86,6 +86,7 @@ public static BreakpointDetails Create(Breakpoint breakpoint)
                 Verified = true,
                 Source = lineBreakpoint.Script,
                 LineNumber = lineBreakpoint.Line,
+                ColumnNumber = lineBreakpoint.Column,
                 Condition = lineBreakpoint.Action?.ToString()
             };