Now the diagnostics records update when you change the scriptAnalysisSettingsPath.

Author: rkeithhill

src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs

@@ -318,17 +318,20 @@ protected async Task HandleDidChangeConfigurationNotification(
             }
 
             // If there is a new settings file path, restart the analyzer with the new settigs.
+            bool settingsPathChanged = false;
             string newSettingsPath = this.currentSettings.ScriptAnalysis.SettingsPath;
             if (!(oldScriptAnalysisSettingsPath?.Equals(newSettingsPath, StringComparison.OrdinalIgnoreCase) ?? false))
             {
                 this.editorSession.RestartAnalysisService(newSettingsPath);
+                settingsPathChanged = true;
             }
 
-            if (oldScriptAnalysisEnabled != this.currentSettings.ScriptAnalysis.Enable)
+            // If script analysis settings have changed we need to clear & possibly update the current diagnostic records.
+            if ((oldScriptAnalysisEnabled != this.currentSettings.ScriptAnalysis.Enable) || settingsPathChanged)
             {
-                // If the user just turned off script analysis, send a diagnostics
-                // event to clear the analysis markers that they already have
-                if (!this.currentSettings.ScriptAnalysis.Enable.Value)
+                // If the user just turned off script analysis or changed the settings path, send a diagnostics
+                // event to clear the analysis markers that they already have.
+                if (!this.currentSettings.ScriptAnalysis.Enable.Value || settingsPathChanged)
                 {
                     ScriptFileMarker[] emptyAnalysisDiagnostics = new ScriptFileMarker[0];
 
@@ -340,6 +343,15 @@ await PublishScriptDiagnostics(
                             eventContext);
                     }
                 }
+
+                // If script analysis is enabled and the settings file changed get new diagnostic records.
+                if (this.currentSettings.ScriptAnalysis.Enable.Value && settingsPathChanged)
+                {
+                    await this.RunScriptDiagnostics(
+                        this.editorSession.Workspace.GetOpenedFiles(),
+                        this.editorSession,
+                        eventContext);
+                }
             }
         }