Merge pull request #126 from rkeithhill/rkeithhill/is123-breakpoints-litpath

Fix for issue #123, wildcard chars in script path prevent breakpoints…

Author: daviwil

src/PowerShellEditorServices/Debugging/DebugService.cs

@@ -77,9 +77,13 @@ public async Task<BreakpointDetails[]> SetBreakpoints(
 
             if (lineNumbers.Length > 0)
             {
+                // Fix for issue #123 - file paths that contain wildcard chars [ and ] need to
+                // quoted and have those wildcard chars escaped.
+                string escapedScriptPath = PowerShellContext.EscapeWildcardsInPath(scriptFile.FilePath);
+
                 PSCommand psCommand = new PSCommand();
                 psCommand.AddCommand("Set-PSBreakpoint");
-                psCommand.AddParameter("Script", scriptFile.FilePath);
+                psCommand.AddParameter("Script", escapedScriptPath);
                 psCommand.AddParameter("Line", lineNumbers.Length > 0 ? lineNumbers : null);
 
                 resultBreakpoints =

src/PowerShellEditorServices/Session/PowerShellContext.cs

@@ -435,8 +435,13 @@ public async Task<IEnumerable<object>> ExecuteScriptString(
         /// <returns>A Task that can be awaited for completion.</returns>
         public async Task ExecuteScriptAtPath(string scriptPath)
         {
+            // If we don't escape wildcard characters in the script path, the script can
+            // fail to execute if say the script name was foo][.ps1.
+            // Related to issue #123.
+            string escapedScriptPath = EscapeWildcardsInPath(scriptPath);
+
             PSCommand command = new PSCommand();
-            command.AddCommand(scriptPath);
+            command.AddCommand(escapedScriptPath);
 
             await this.ExecuteCommand<object>(command, true);
         }
@@ -547,6 +552,16 @@ internal void ReleaseRunspaceHandle(RunspaceHandle runspaceHandle)
             }
         }
 
+        /// <summary>
+        /// Returns the passed in path with the [ and ] wildcard characters escaped.
+        /// </summary>
+        /// <param name="path">The path to process.</param>
+        /// <returns>The path with [ and ] escaped.</returns>
+        internal static string EscapeWildcardsInPath(string path)
+        {
+            return path.Replace("[", "`[").Replace("]", "`]");
+        }
+
         #endregion
 
         #region Events