Use rule path parameters from settings file

Author: Kapil Borle

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -265,6 +265,9 @@ protected override void BeginProcessing()
                 ProcessPath();
             }
 
+            string[] combRulePaths = null;
+            var combRecurseCustomRulePath = RecurseCustomRulePath.IsPresent;
+            var combIncludeDefaultRules = IncludeDefaultRules.IsPresent;
             try
             {
                 var settingsObj = PSSASettings.Create(
@@ -274,7 +277,26 @@ protected override void BeginProcessing()
                 if (settingsObj != null)
                 {
                     ScriptAnalyzer.Instance.UpdateSettings(settingsObj);
+
+                    // For includeDefaultRules and RecurseCustomRulePath we override the value in the settings file by
+                    // command line argument.
+                    combRecurseCustomRulePath = combRecurseCustomRulePath || settingsObj.RecurseCustomRulePath;
+                    combIncludeDefaultRules = combIncludeDefaultRules || settingsObj.IncludeDefaultRules;
                 }
+
+                // Ideally we should not allow the parameter to be set from settings and command line
+                // simultaneously. But since, this was done before with IncludeRules, ExcludeRules and Severity,
+                // we use the same strategy for CustomRulePath. So, we take the union of CustomRulePath provided in
+                // the settings file and if provided on command line.
+                var settingsCustomRulePath = Helper.ProcessCustomRulePaths(
+                        settingsObj?.CustomRulePath?.ToArray(),
+                        this.SessionState,
+                        combRecurseCustomRulePath);
+                    combRulePaths = rulePaths == null
+                                                ? settingsCustomRulePath
+                                                : settingsCustomRulePath == null
+                                                    ? rulePaths
+                                                    : rulePaths.Concat(settingsCustomRulePath).ToArray();
             }
             catch
             {
@@ -285,11 +307,11 @@ protected override void BeginProcessing()
 
             ScriptAnalyzer.Instance.Initialize(
                 this,
-                rulePaths,
+                combRulePaths,
                 this.includeRule,
                 this.excludeRule,
                 this.severity,
-                null == rulePaths ? true : this.includeDefaultRules,
+                combRulePaths == null || combIncludeDefaultRules,
                 this.suppressedOnly);
         }