Merge pull request #322 from kapilmb/FixAvoidInvokingEmptyMembers

Fixes the documentation of AvoidInvokingEmptyMembers rule.

Author: Kapil Borle

RuleDocumentation/AvoidInvokingEmptyMembers.md

@@ -4,7 +4,7 @@
 
 ##Description
 
-Invoking non-constant members would cause potential bugs. Please double check the syntax to make sure members invoked are non-constant.
+Invoking non-constant members would cause potential bugs. Please double check the syntax to make sure that invoked members are constants.
 
 
 ##How to Fix

Rules/AvoidInvokingEmptyMembers.cs

@@ -20,14 +20,15 @@
 
 namespace Microsoft.Windows.PowerShell.ScriptAnalyzer.BuiltinRules
 {
+    // Rule name is inconsistent.
     /// <summary>
-    /// AvoidAlias: Check if cmdlet alias is used.
-    /// </summary>
+    /// AvoidInvokingEmptyMembers: Analyzes the script to check if any non-constant members have been invoked.
+    /// </summary>    
     [Export(typeof(IScriptRule))]
     public class AvoidInvokingEmptyMembers : IScriptRule
     {
         /// <summary>
-        /// AnalyzeScript: Analyze the script to check if any empty members has been invoked.
+        /// AnalyzeScript: Analyzes the script to check if any non-constant members have been invoked.
         /// </summary>
         public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
         {

Rules/Strings.Designer.cs

@@ -526,7 +526,7 @@
     <value>Invoking non-constant members would cause potential bugs. Please double check the syntax to make sure members invoked are non-constant.</value>
   </data>
   <data name="AvoidInvokingEmptyMembersError" xml:space="preserve">
-    <value>'{0}' has non-constant members. Invoking empty members may cause bugs in the script.</value>
+    <value>'{0}' has non-constant members. Invoking non-constant members may cause bugs in the script.</value>
   </data>
   <data name="AvoidInvokingEmptyMembersName" xml:space="preserve">
     <value>AvoidInvokingEmptyMembers</value>

Rules/Strings.resx

@@ -1,6 +1,6 @@
 Import-Module PSScriptAnalyzer
 
-$violationMessage = "() has non-constant members. Invoking empty members may cause bugs in the script."
+$violationMessage = "() has non-constant members. Invoking non-constant members may cause bugs in the script."
 $violationName = "PSAvoidInvokingEmptyMembers"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violations = Invoke-ScriptAnalyzer $directory\AvoidInvokingEmptyMembers.ps1 | Where-Object {$_.RuleName -eq $violationName}