Remove redundant code in digraph class

Author: Kapil Borle

Engine/Helper.cs

@@ -3572,7 +3572,10 @@ public Digraph()
         }
 
         /// <summary>
-        /// Construct digraph with an EqualityComparer used for comparing type T
+        /// Construct a directed graph that uses an EqualityComparer object for comparison with its vertices
+        ///
+        /// The class allows its client to use their choice of vertex type. To allow comparison for such a
+        /// vertex type, client can pass their own EqualityComparer object
         /// </summary>
         /// <param name="equalityComparer"></param>
         public Digraph(IEqualityComparer<T> equalityComparer) : this()
@@ -3728,21 +3731,18 @@ private bool IsConnected(int fromIdx, int toIdx, ref bool[] visited)
                 return true;
             }
 
-            bool isConnected = false;
             foreach(var vertexIdx in graph[fromIdx])
             {
                 if (!visited[vertexIdx])
                 {
-                    isConnected |= IsConnected(vertexIdx, toIdx, ref visited);
-                }
-
-                if (isConnected) // no need to search further
-                {
-                    break;
+                    if(IsConnected(vertexIdx, toIdx, ref visited))
+                    {
+                        return true;
+                    }
                 }
             }
 
-            return isConnected;
+            return false;
         }
 
         /// <summary>

Rules/UseShouldProcessCorrectly.cs

@@ -140,13 +140,13 @@ private void FindViolations()
         /// <returns>An instance of DiagnosticRecord if it find violation, otherwise null</returns>
         private DiagnosticRecord GetViolation(Vertex v)
         {
-            bool callsShouldProcess = funcDigraph.IsConnected(v, shouldProcessVertex);
             FunctionDefinitionAst fast = v.Ast as FunctionDefinitionAst;
             if (fast == null)
             {
                 return null;
             }
 
+            bool callsShouldProcess = funcDigraph.IsConnected(v, shouldProcessVertex);
             if (DeclaresSupportsShouldProcess(fast))
             {
                 if (!callsShouldProcess)