Parse string literal as argument in settings file

Author: Kapil Borle

Engine/Settings.cs

@@ -416,14 +416,15 @@ private Hashtable GetHashtableFromHashTableAst(HashtableAst hashTableAst)
                         var strConstExprAst = constExprAst as StringConstantExpressionAst;
                         if (strConstExprAst != null)
                         {
-                            rhsList.Add(strConstExprAst.Value);
+                            // it is a string literal
+                            output[key] = strConstExprAst.Value;
                         }
                         else
                         {
                             // it is either an integer or a float
                             output[key] = constExprAst.Value;
-                            continue;
                         }
+                        continue;
                     }
                     else if (pureExp is HashtableAst)
                     {

Tests/Engine/Settings.tests.ps1

@@ -99,7 +99,7 @@ Describe "Settings Class" {
         }
 
         It "Should return 1 rule argument" {
-            $settings.RuleArguments.Count | Should Be 2
+            $settings.RuleArguments.Count | Should Be 3
         }
 
         It "Should parse boolean type argument" {
@@ -109,5 +109,9 @@ Describe "Settings Class" {
         It "Should parse int type argument" {
             $settings.RuleArguments["PSUseConsistentIndentation"]["IndentationSize"] | Should Be 4
         }
+
+        It "Should parse string literal" {
+            $settings.RuleArguments["PSProvideCommentHelp"]["Placement"] | Should Be 'end'
+        }
     }
-}
+}

Tests/Engine/SettingsTest/Project1/ExplicitSettings.psd1

@@ -1,14 +1,19 @@
 @{
     "IncludeRules" = @("PSAvoidUsingCmdletAliases", "PSAvoidUsingWriteHost", "PSUseConsistentIndentation")
     "ExcludeRules" = @("PSShouldProcess", "PSAvoidUsingWMICmdlet", "PSUseCmdletCorrectly")
-    "rules" = @{
-        PSAvoidUsingCmdletAliases = @{
+    "rules"        = @{
+        PSAvoidUsingCmdletAliases  = @{
             WhiteList = @("cd", "cp")
         }
 
         PSUseConsistentIndentation = @{
             Enable = $true
             IndentationSize = 4
         }
+
+        PSProvideCommentHelp       = @{
+            Enable = $true
+            Placement = 'end'
+        }
     }
-}
+}