Change return type of FunctionDefinitionAst.GetParameters

Author: Kapil Borle

Engine/Extensions.cs

@@ -26,19 +26,19 @@ public static Range ToRange(this IScriptExtent extent)
                  extent.EndColumnNumber);
         }
 
-        public static ParameterAst[] GetParameterAsts(
+        public static IEnumerable<ParameterAst> GetParameterAsts(
             this FunctionDefinitionAst functionDefinitionAst,
             out ParamBlockAst paramBlockAst)
         {
             paramBlockAst = null;
             if (functionDefinitionAst.Parameters != null)
             {
-                return new List<ParameterAst>(functionDefinitionAst.Parameters).ToArray();
+                return functionDefinitionAst.Parameters;
             }
             else if (functionDefinitionAst.Body.ParamBlock?.Parameters != null)
             {
                 paramBlockAst = functionDefinitionAst.Body.ParamBlock;
-                return new List<ParameterAst>(functionDefinitionAst.Body.ParamBlock.Parameters).ToArray();
+                return functionDefinitionAst.Body.ParamBlock.Parameters;
             }
 
             return null;
@@ -54,7 +54,7 @@ public static AttributeAst GetCmdletBindingAttributeAst(this ParamBlockAst param
             var attributeAsts = paramBlockAst.Attributes;
             if (attributeAsts == null)
             {
-                throw new ArgumentNullException("attributeAsts");
+                return null;
             }
 
             foreach (var attributeAst in attributeAsts)

rules/UseSupportsShouldProcess.cs

@@ -65,7 +65,7 @@ private List<DiagnosticRecord> FindViolations()
                 int whatIfIndex, confirmIndex;
                 ParameterAst whatIfParamAst, confirmParamAst;
                 ParamBlockAst paramBlockAst;
-                ParameterAst[] parameterAsts = functionDefinitionAst.GetParameterAsts(out paramBlockAst);
+                var parameterAsts = functionDefinitionAst.GetParameterAsts(out paramBlockAst).ToArray();
                 if (parameterAsts == null)
                 {
                     continue;