Merge pull request #752 from PowerShell/kapilmb/fix-avoid-global-var-rule

Excludes lastexitcode from AvoidGlobalVars checks

Author: Kapil Borle

Engine/SpecialVars.cs

@@ -164,6 +164,7 @@ internal enum PreferenceVariable
         internal const string Null = "null";
         internal const string True = "true";
         internal const string False = "false";
+        internal const string LastExitCode = "LastExitCode";
 
         internal static readonly string[] OtherInitializedVariables = new string[]
                                                                 {
@@ -184,7 +185,8 @@ internal enum PreferenceVariable
                                                                     pwd,
                                                                     Null,
                                                                     True,
-                                                                    False
+                                                                    False,
+                                                                    LastExitCode
                                                                 };
 
     }

Tests/Rules/AvoidGlobalOrUnitializedVars.tests.ps1

@@ -28,7 +28,7 @@ Describe "AvoidGlobalVars" {
         It "has 1 avoid using global variable violation" {
             $globalViolations.Count | Should Be 1
         }
-                
+
         <#
         # PSAvoidUninitializedVariable rule has been deprecated
         It "has 4 violations for dsc resources (not counting the variables in parameters)" {
@@ -47,6 +47,19 @@ Describe "AvoidGlobalVars" {
             $noGlobalViolations.Count | Should Be 0
         }
     }
+
+    Context "When a script contains global:lastexitcode" {
+        It "returns no violation" {
+            $def = @'
+if ($global:lastexitcode -ne 0)
+{
+    exit
+}
+'@
+            $local:violations = Invoke-ScriptAnalyzer -ScriptDefinition $def -IncludeRule $globalName
+            $local:violations.Count | Should Be 0
+        }
+    }
 }
 
 <#
@@ -66,6 +79,6 @@ Describe "AvoidUnitializedVars" {
         It "returns no violations" {
             $noUninitializedViolations.Count | Should Be 0
         }
-    }    
+    }
 }
-#>
+#>