Add runspace pool to improve getcommandinfo perf

Author: Kapil Borle

Engine/Commands/GetScriptAnalyzerRuleCommand.cs

@@ -129,6 +129,20 @@ protected override void ProcessRecord()
             }
         }
 
+        protected override void EndProcessing()
+        {
+            ScriptAnalyzer.Instance.CleanUp();
+            Helper.Instance.CleanUp();
+            base.EndProcessing();
+        }
+
+        protected override void StopProcessing()
+        {
+            ScriptAnalyzer.Instance.CleanUp();
+            Helper.Instance.CleanUp();
+            base.StopProcessing();
+        }
+
         #endregion
     }
 }

Engine/Commands/InvokeScriptAnalyzerCommand.cs

@@ -337,12 +337,14 @@ protected override void ProcessRecord()
         protected override void EndProcessing()
         {
             ScriptAnalyzer.Instance.CleanUp();
+            Helper.Instance.CleanUp();
             base.EndProcessing();
         }
 
         protected override void StopProcessing()
         {
             ScriptAnalyzer.Instance.CleanUp();
+            Helper.Instance.CleanUp();
             base.StopProcessing();
         }
 

Engine/Helper.cs

@@ -39,6 +39,7 @@ public class Helper
         private Dictionary<string, Dictionary<string, object>> ruleArguments;
         private PSVersionTable psVersionTable;
         private Dictionary<string, CommandInfo> commandInfoCache;
+        private RunspacePool runspacePool;
 
         #endregion
 
@@ -148,6 +149,8 @@ public void Initialize()
             VariableAnalysisDictionary = new Dictionary<Ast, VariableAnalysis>();
             ruleArguments = new Dictionary<string, Dictionary<string, object>>(StringComparer.OrdinalIgnoreCase);
             commandInfoCache = new Dictionary<string, CommandInfo>(StringComparer.OrdinalIgnoreCase);
+            runspacePool = RunspaceFactory.CreateRunspacePool(InitialSessionState.CreateDefault2());
+            runspacePool.Open();
 
             IEnumerable<CommandInfo> aliases = this.invokeCommand.GetCommands("*", CommandTypes.Alias, true);
 
@@ -166,6 +169,14 @@ public void Initialize()
             }
         }
 
+        /// <summary>
+        /// We are forced to use this to improve performace
+        /// </summary>
+        public void CleanUp()
+        {
+            runspacePool.Dispose();
+        }
+
         /// <summary>
         /// Returns all the rule arguments
         /// </summary>
@@ -699,6 +710,7 @@ private CommandInfo GetCommandInfoInternal(string cmdName, CommandTypes? command
         {
             using (var ps = System.Management.Automation.PowerShell.Create())
             {
+                ps.RunspacePool = runspacePool;
                 var cmdInfo = ps.AddCommand("Get-Command")
                                 .AddArgument(cmdName)
                                 .AddParameter("ErrorAction", "SilentlyContinue")