Set the severity level of AvoidUsingConvertToSecureStringWithPlainText

Author: Kapil Borle

Rules/AvoidUsingConvertToSecureStringWithPlainText.cs

@@ -113,7 +113,7 @@ public override SourceType GetSourceType()
         /// <returns></returns>
         public override RuleSeverity GetSeverity()
         {
-            return RuleSeverity.Warning;
+            return RuleSeverity.Error;
         }
 
         /// <summary>
@@ -122,7 +122,7 @@ public override RuleSeverity GetSeverity()
         /// <returns></returns>
         public override DiagnosticSeverity GetDiagnosticSeverity()
         {
-            return DiagnosticSeverity.Warning;
+            return DiagnosticSeverity.Error;
         }
 
         /// <summary>

Tests/Engine/GetScriptAnalyzerRule.tests.ps1

@@ -126,17 +126,17 @@ Describe "Test RuleExtension" {
 Describe "TestSeverity" {
     It "filters rules based on the specified rule severity" {
         $rules = Get-ScriptAnalyzerRule -Severity Error
-        $rules.Count | Should be 5
+        $rules.Count | Should be 6
     }
 
     It "filters rules based on multiple severity inputs"{
         $rules = Get-ScriptAnalyzerRule -Severity Error,Information
-        $rules.Count | Should be 12
+        $rules.Count | Should be 13
     }
 
         It "takes lower case inputs" {
         $rules = Get-ScriptAnalyzerRule -Severity error
-        $rules.Count | Should be 5
+        $rules.Count | Should be 6
     }
 }