Fix test failures

Author: Quoc Truong

Tests/Engine/LibraryUsage.tests.ps1

@@ -6,10 +6,15 @@ $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 # wraps the usage of ScriptAnalyzer as a .NET library 
 function Invoke-ScriptAnalyzer {
 	param (
-		[parameter(Mandatory = $true, Position = 0)]
+        [CmdletBinding(DefaultParameterSetName="File")]
+
+		[parameter(Mandatory = $true, Position = 0, ParameterSetName="File")]
 		[Alias("PSPath")]
 		[string] $Path,
 
+		[parameter(Mandatory = $true, ParameterSetName="ScriptDefinition")]
+		[string] $ScriptDefinition,
+
         [Parameter(Mandatory = $false)]
 		[string[]] $CustomizedRulePath = $null,
 
@@ -41,7 +46,12 @@ function Invoke-ScriptAnalyzer {
 		$SuppressedOnly.IsPresent
 	);
 
-	return $scriptAnalyzer.AnalyzePath($Path, $Recurse.IsPresent);
+    if ($PSCmdlet.ParameterSetName -eq "File") {
+    	return $scriptAnalyzer.AnalyzePath($Path, $Recurse.IsPresent);
+    }
+    else {
+        return $scriptAnalyzer.AnalyzeScriptDefinition($ScriptDefinition);
+    }
 }
 
 # Define an implementation of the IOutputWriter interface

Tests/Engine/RuleSuppression.tests.ps1

@@ -14,6 +14,7 @@ Describe "RuleSuppressionWithoutScope" {
     Context "Function" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object { $_.RuleName -eq "PSProvideCommentHelp" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object { $_.RuleName -eq "PSProvideCommentHelp" }
             $suppression.Count | Should Be 0
         }
@@ -22,6 +23,7 @@ Describe "RuleSuppressionWithoutScope" {
     Context "Class" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSAvoidUsingInvokeExpression" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSAvoidUsingInvokeExpression" }
             $suppression.Count | Should Be 0
         }
@@ -30,6 +32,7 @@ Describe "RuleSuppressionWithoutScope" {
     Context "FunctionInClass" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSAvoidUsingCmdletAliases" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSAvoidUsingCmdletAliases" }
             $suppression.Count | Should Be 0
         }        
@@ -38,6 +41,7 @@ Describe "RuleSuppressionWithoutScope" {
     Context "Script" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSProvideCommentHelp" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSProvideCommentHelp" }
             $suppression.Count | Should Be 0
         }
@@ -46,6 +50,7 @@ Describe "RuleSuppressionWithoutScope" {
     Context "RuleSuppressionID" {
         It "Only suppress violations for that ID" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSProvideDefaultParameterValue" }
+            $suppression.Count | Should Be 1
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSProvideDefaultParameterValue" }
             $suppression.Count | Should Be 1
         }
@@ -56,6 +61,7 @@ Describe "RuleSuppressionWithScope" {
     Context "FunctionScope" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSAvoidUsingPositionalParameters" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSAvoidUsingPositionalParameters" }
             $suppression.Count | Should Be 0
         }
@@ -64,6 +70,7 @@ Describe "RuleSuppressionWithScope" {
     Context "ClassScope" {
         It "Does not raise violations" {
             $suppression = $violations | Where-Object {$_.RuleName -eq "PSAvoidUsingConvertToSecureStringWithPlainText" }
+            $suppression.Count | Should Be 0
             $suppression = $violationsUsingScriptDefinition | Where-Object {$_.RuleName -eq "PSAvoidUsingConvertToSecureStringWithPlainText" }
             $suppression.Count | Should Be 0
         }