add multiline test

Author: Steve Lee (POWERSHELL HE/HIM) (from Dev Box)

dsc/tests/dsc_extension_secret.tests.ps1

@@ -116,4 +116,19 @@ Describe 'Tests for the secret() function and extensions' {
         $out.results.Count | Should -Be 1
         $out.results[0].result.actualState.Output | Should -BeExactly 'SameSecret'
     }
+
+    It 'Secret with multiple lines' {
+        $configYaml = @'
+            $schema: https://aka.ms/dsc/schemas/v3/bundled/config/document.json
+            resources:
+            - name: Echo
+              type: Microsoft.DSC.Debug/Echo
+              properties:
+                output: "[secret('MultiLine')]"
+'@
+        dsc -l trace config get -i $configYaml 2> $TestDrive/error.log | ConvertFrom-Json
+        $LASTEXITCODE | Should -Be 2
+        $errorMessage = Get-Content -Raw -Path $TestDrive/error.log
+        $errorMessage | Should -Match "Extension 'Test/Secret2' returned multiple lines which is not supported for secrets"
+    }
 }

dsc_lib/locales/en-us.toml

@@ -188,6 +188,7 @@ secretNoResults = "Extension '%{extension}' returned no output"
 importingFile = "Importing file '%{file}' with extension '%{extension}'"
 importNotSupported = "Import is not supported by extension '%{extension}' for file '%{file}'"
 importNoResults = "Extension '%{extension}' returned no results for import"
+secretMultipleLinesReturned = "Extension '%{extension}' returned multiple lines which is not supported for secrets"
 
 [extensions.extension_manifest]
 extensionManifestSchemaTitle = "Extension manifest schema URI"

dsc_lib/src/extensions/dscextension.rs

@@ -245,8 +245,15 @@ impl DscExtension {
                 info!("{}", t!("extensions.dscextension.secretNoResults", extension = self.type_name));
                 Ok(None)
             } else {
-                debug!("{}", t!("extensions.dscextension.extensionReturnedSecret", extension = self.type_name));
-                Ok(Some(stdout))
+                // see if multiple lines were returned
+                let secret = if stdout.lines().count() > 1 {
+                    return Err(DscError::NotSupported(t!("extensions.dscextension.secretMultipleLinesReturned", extension = self.type_name).to_string()));
+                } else {
+                    debug!("{}", t!("extensions.dscextension.extensionReturnedSecret", extension = self.type_name));
+                    // remove any trailing newline characters
+                    stdout.trim_end_matches('\n').to_string()
+                };
+                Ok(Some(secret))
             }
         } else {
             Err(DscError::UnsupportedCapability(

extensions/test/secret/secret.ps1

@@ -27,6 +27,7 @@ $secretTwo = @{
         DifferentSecret = 'Hello2'
         DuplicateSecret = 'World2'
         DuplicateSame = 'SameSecret'
+        MultiLine = "This`nis`nmultiline"
     }
 }