Skip to content

Commit b4f0fb2

Browse files
authored
Merge pull request #1205 from SteveL-MSFT/echo-schema
Fix `Echo` resource to have correct type for object
2 parents baa9465 + 8cbc5db commit b4f0fb2

File tree

2 files changed

+9
-4
lines changed

2 files changed

+9
-4
lines changed

resources/dscecho/src/echo.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
use schemars::JsonSchema;
55
use serde::{Deserialize, Serialize};
6-
use serde_json::Value;
6+
use serde_json::{Map, Value};
77

88
#[derive(Debug, Clone, PartialEq, Deserialize, Serialize, JsonSchema)]
99
#[serde(untagged)]
@@ -22,7 +22,9 @@ pub enum Output {
2222
String(String),
2323
// Object has to be last so it doesn't get matched first
2424
#[serde(rename = "object")]
25-
Object(Value),
25+
Object(Map<String,Value>),
26+
#[serde(rename = "null")]
27+
Null,
2628
}
2729

2830
#[derive(Debug, Clone, PartialEq, Deserialize, Serialize, JsonSchema)]
@@ -36,7 +38,7 @@ pub struct SecureString {
3638
#[serde(deny_unknown_fields)]
3739
pub struct SecureObject {
3840
#[serde(rename = "secureObject")]
39-
pub secure_object: Value,
41+
pub secure_object: Map<String,Value>,
4042
}
4143

4244
#[derive(Debug, Clone, PartialEq, Deserialize, Serialize, JsonSchema)]

resources/dscecho/src/main.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,10 @@ fn main() {
4040
}
4141
},
4242
Output::Object(ref mut obj) => {
43-
*obj = redact(obj);
43+
*obj = redact(&Value::Object(obj.clone()))
44+
.as_object()
45+
.expect("Expected redact() to return a Value::Object")
46+
.clone();
4447
},
4548
_ => {}
4649
}

0 commit comments

Comments
 (0)