fix copilot issues

Author: SteveL-MSFT

dsc/src/subcommand.rs

@@ -496,7 +496,7 @@ pub fn validate_config(config: &Configuration, progress_format: ProgressFormat)
         let Some(type_name) = resource_block["type"].as_str() else {
             return Err(DscError::Validation(t!("subcommand.resourceTypeNotSpecified").to_string()));
         };
-        resource_types.push(DiscoveryFilter::new(&type_name.to_lowercase(), resource_block["api_version"].as_str().map(std::string::ToString::to_string)));
+        resource_types.push(DiscoveryFilter::new(&type_name, resource_block["api_version"].as_str().map(std::string::ToString::to_string)));
     }
     dsc.find_resources(&resource_types, progress_format);
 

dsc/tests/dsc_resource_set.tests.ps1

@@ -14,4 +14,4 @@ Describe 'Invoke a resource set directly' {
         $out.afterState.version | Should -BeExactly '1.1.2'
         $out.changedProperties | Should -BeNullOrEmpty
     }
-}
+}

dsc/tests/dsc_resource_test.tests.ps1

@@ -33,4 +33,4 @@ Describe 'Invoke a resource test directly' {
         $out.actualState.version | Should -BeExactly '1.1.2'
         $out.inDesiredState | Should -Be $true
     }
-}
+}

dsc_lib/src/discovery/command_discovery.rs

@@ -548,11 +548,12 @@ fn filter_resources(found_resources: &mut BTreeMap<String, Vec<DscResource>>, re
             }
         }
         if required_resources.values().all(|&v| v) {
-            break;
+            return;
         }
     }
 }
 
+/// Inserts a resource into tree adding to vector if already exists
 fn insert_resource(resources: &mut BTreeMap<String, Vec<DscResource>>, resource: &DscResource) {
     if let Some(resource_versions) = resources.get_mut(&resource.type_name.to_lowercase()) {
         // compare the resource versions and insert newest to oldest using semver

dsc_lib/src/discovery/mod.rs

@@ -158,9 +158,16 @@ impl Discovery {
     }
 }
 
+/// Fix the semantic versioning requirements of a given version requirements string.
+/// The `semver` crate uses caret (meaning compatible) by default instead of exact if not specified
+///
+/// # Parameters
+/// * `version` - The version requirements string to fix.
+///
+/// # Returns
+/// The fixed version requirements string.
 #[must_use]
 pub fn fix_semver(version: &str) -> String {
-    // The semver crate uses caret (meaning compatible) by default instead of exact if not specified
     // Check if is semver, then if the first character is a number, then we prefix with =
     if Version::parse(version).is_ok() && version.chars().next().is_some_and(|c| c.is_ascii_digit()) {
         return format!("={version}");