fix tests

Author: Steve Lee (POWERSHELL HE/HIM) (from Dev Box)

dsc/tests/dsc_extension_discover.tests.ps1

@@ -1,6 +1,14 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
+BeforeDiscovery {
+    try {
+        $windowWidth = [Console]::WindowWidth
+    } catch {
+        $consoleUnavailable = $true
+    }
+}
+
 Describe 'Discover extension tests' {
     BeforeAll {
         $oldPath = $env:PATH
@@ -110,12 +118,12 @@ Describe 'Discover extension tests' {
         }
     }
 
-    It 'Table can be not truncated' {
+    It 'Table can be not truncated' -Skip:($consoleUnavailable) {
         $output = dsc extension list --output-format table-no-truncate
         $LASTEXITCODE | Should -Be 0
         $foundWideLine = $false
         foreach ($line in $output) {
-            if ($line.Length -gt [Console]::WindowWidth) {
+            if ($line.Length -gt $windowWidth) {
                 $foundWideLine = $true
             }
         }

dsc/tests/dsc_resource_list.tests.ps1

@@ -1,6 +1,14 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
+BeforeDiscovery {
+    try {
+        $windowWidth = [Console]::WindowWidth
+    } catch {
+        $consoleUnavailable = $true
+    }
+}
+
 Describe 'Tests for listing resources' {
     It 'dsc resource list' {
         $resources = dsc resource list | ConvertFrom-Json -Depth 10
@@ -89,12 +97,12 @@ Describe 'Tests for listing resources' {
         $out | Should -BeLike "*ERROR*Adapter not found: foo`*"
     }
 
-    It 'Table is not truncated' {
+    It 'Table is not truncated' -Skip:($consoleUnavailable) {
         $output = dsc resource list --output-format table-no-truncate
         $LASTEXITCODE | Should -Be 0
         $foundWideLine = $false
         foreach ($line in $output) {
-            if ($line.Length -gt [Console]::WindowWidth) {
+            if ($line.Length -gt $windowWidth) {
                 $foundWideLine = $true
                 break
             }

extensions/appx/appx.tests.ps1

@@ -1,7 +1,11 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
-Describe 'Tests for Appx resource discovery' -Skip:(!$IsWindows){
+BeforeDiscovery {
+    $runningInCI = $null -ne $env:GITHUB_RUN_ID
+}
+
+Describe 'Tests for Appx resource discovery' -Skip:(!$IsWindows -or $runningInCI) {
     It 'Should find DSC appx resources' {
         $out = dsc resource list | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0

extensions/bicep/bicep.tests.ps1

@@ -15,6 +15,7 @@ Describe 'Bicep extension tests' -Skip:(!$foundBicep) {
         $out = dsc -l trace config get -f $bicepFile 2>$TestDrive/error.log | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 0 -Because (Get-Content -Path $TestDrive/error.log -Raw | Out-String)
         $out.results[0].result.actualState.output | Should -BeExactly 'Hello, world!'
+        $bicepFile = $bicepFile.ToString().Replace('\', '\\')
         (Get-Content -Path $TestDrive/error.log -Raw) | Should -Match "Importing file '$bicepFile' with extension 'Microsoft.DSC.Extension/Bicep'"
     }
 
@@ -28,9 +29,10 @@ resource invalid 'Microsoft.DSC.Extension/Bicep:1.0' = {
     properties: {
         output: 'This is invalid'
 "@
-        $out = dsc -l trace config get -f $bicepFile 2>$TestDrive/error.log | ConvertFrom-Json
+        dsc -l trace config get -f $bicepFile 2>$TestDrive/error.log | ConvertFrom-Json
         $LASTEXITCODE | Should -Be 4 -Because (Get-Content -Path $TestDrive/error.log -Raw | Out-String)
         $content = (Get-Content -Path $TestDrive/error.log -Raw)
+        $bicepFile = $bicepFile.ToString().Replace('\', '\\')
         $content | Should -Match "Importing file '$bicepFile' with extension 'Microsoft.DSC.Extension/Bicep'"
         $content | Should -Match "BCP033"
     }

reboot_pending/tests/reboot_pending.tests.ps1

@@ -1,6 +1,14 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
+BeforeDiscovery {
+    if ($IsWindows) {
+        $identity = [System.Security.Principal.WindowsIdentity]::GetCurrent()
+        $principal = [System.Security.Principal.WindowsPrincipal]::new($identity)
+        $isElevated = $principal.IsInRole([System.Security.Principal.WindowsBuiltInRole]::Administrator)
+    }
+}
+
 Describe 'reboot_pending resource tests' {
     It 'should get reboot_pending' -Skip:(!$IsWindows) {
         $out = dsc resource get -r Microsoft.Windows/RebootPending | ConvertFrom-Json
@@ -15,17 +23,17 @@ Describe 'reboot_pending resource tests' {
         $out.results.result.actualState.rebootPending | Should -Not -BeNullOrEmpty
     }
 
-    It 'reboot_pending should have a reason' -Skip:(!$IsWindows) {
+    It 'reboot_pending should have a reason' -Skip:(!$IsWindows -or !$isElevated) {
         $keyPath = "HKLM:\SOFTWARE\Microsoft\Windows\CurrentVersion\WindowsUpdate\Auto Update"
         $keyName = "RebootRequired"
         try {
             if (-not (Get-ItemProperty "$keyPath\$keyName" -ErrorAction SilentlyContinue)) {
                 New-ItemProperty -Path $keyPath -Name $keyName -Value 1 -PropertyType DWord -Force | Out-Null
             }
 
-            $out | dsc resource get -r Microsoft.Windows/RebootPending | ConvertFrom-Json
+            $out = dsc resource get -r Microsoft.Windows/RebootPending | ConvertFrom-Json
             $LASTEXITCODE | Should -Be 0
-            $out.actualState.reason.count | Should -BeGreaterThan 0
+            $out.actualState.reason.count | Should -BeGreaterThan 0 -Because ($out | Out-String)
         } finally {
             Remove-ItemProperty -Path $keyPath -Name $keyName -ErrorAction Ignore
         }