refactor common code

Author: SteveL-MSFT

dsc_lib/src/configure/mod.rs

@@ -311,13 +311,9 @@ impl Configurator {
         for resource in resources {
             progress.set_resource(&resource.name, &resource.resource_type);
             progress.write_activity(format!("Get '{}'", resource.name).as_str());
-            if let Some(condition) = &resource.condition {
-                let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
-                if condition_result != Value::Bool(true) {
-                    info!("{}", t!("configure.config_doc.skippingResource", name = resource.name, condition = condition, result = condition_result));
-                    progress.write_increment(1);
-                    continue;
-                }
+            if self.skip_resource(&resource)? {
+                progress.write_increment(1);
+                continue;
             }
             let Some(dsc_resource) = discovery.find_resource(&resource.resource_type) else {
                 return Err(DscError::ResourceNotFound(resource.resource_type));
@@ -395,13 +391,9 @@ impl Configurator {
         for resource in resources {
             progress.set_resource(&resource.name, &resource.resource_type);
             progress.write_activity(format!("Set '{}'", resource.name).as_str());
-            if let Some(condition) = &resource.condition {
-                let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
-                if condition_result != Value::Bool(true) {
-                    info!("{}", t!("configure.config_doc.skippingResource", name = resource.name, condition = condition, result = condition_result));
-                    progress.write_increment(1);
-                    continue;
-                }
+            if self.skip_resource(&resource)? {
+                progress.write_increment(1);
+                continue;
             }
             let Some(dsc_resource) = discovery.find_resource(&resource.resource_type) else {
                 return Err(DscError::ResourceNotFound(resource.resource_type));
@@ -551,13 +543,9 @@ impl Configurator {
         for resource in resources {
             progress.set_resource(&resource.name, &resource.resource_type);
             progress.write_activity(format!("Test '{}'", resource.name).as_str());
-            if let Some(condition) = &resource.condition {
-                let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
-                if condition_result != Value::Bool(true) {
-                    info!("{}", t!("configure.config_doc.skippingResource", name = resource.name, condition = condition, result = condition_result));
-                    progress.write_increment(1);
-                    continue;
-                }
+            if self.skip_resource(&resource)? {
+                progress.write_increment(1);
+                continue;
             }
             let Some(dsc_resource) = discovery.find_resource(&resource.resource_type) else {
                 return Err(DscError::ResourceNotFound(resource.resource_type));
@@ -632,13 +620,9 @@ impl Configurator {
         for resource in &resources {
             progress.set_resource(&resource.name, &resource.resource_type);
             progress.write_activity(format!("Export '{}'", resource.name).as_str());
-            if let Some(condition) = &resource.condition {
-                let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
-                if condition_result != Value::Bool(true) {
-                    info!("{}", t!("configure.config_doc.skippingResource", name = resource.name, condition = condition, result = condition_result));
-                    progress.write_increment(1);
-                    continue;
-                }
+            if self.skip_resource(resource)? {
+                progress.write_increment(1);
+                continue;
             }
             let Some(dsc_resource) = discovery.find_resource(&resource.resource_type) else {
                 return Err(DscError::ResourceNotFound(resource.resource_type.clone()));
@@ -674,6 +658,17 @@ impl Configurator {
         Ok(result)
     }
 
+    fn skip_resource(&mut self, resource: &Resource) -> Result<bool, DscError> {
+        if let Some(condition) = &resource.condition {
+            let condition_result = self.statement_parser.parse_and_execute(condition, &self.context)?;
+            if condition_result != Value::Bool(true) {
+                info!("{}", t!("configure.config_doc.skippingResource", name = resource.name, condition = condition, result = condition_result));
+                return Ok(true);
+            }
+        }
+        Ok(false)
+    }
+
     /// Set the mounted path for the configuration.
     ///
     /// # Arguments