fix clippy

Author: SteveL-MSFT

dsc_lib/src/discovery/command_discovery.rs

@@ -182,6 +182,7 @@ impl Default for CommandDiscovery {
 
 impl ResourceDiscovery for CommandDiscovery {
 
+    #[allow(clippy::too_many_lines)]
     fn discover(&mut self, kind: &DiscoveryKind, filter: &str) -> Result<(), DscError> {
         info!("{}", t!("discovery.commandDiscovery.discoverResources", filter = filter));
 
@@ -291,7 +292,7 @@ impl ResourceDiscovery for CommandDiscovery {
         match kind {
             DiscoveryKind::Resource => {
                 // Now we need to call discover extensions and add those resource to the list of resources
-                for (_extension_name, extension) in self.extensions.iter() {
+                for extension in self.extensions.values() {
                     if extension.capabilities.contains(&ExtensionCapability::Discover) {
                         debug!("{}", t!("discovery.commandDiscovery.callingExtension", extension = extension.type_name));
                         let discovered_resources = extension.discover()?;

dsc_lib/src/extensions/dscextension.rs

@@ -64,6 +64,15 @@ impl DscExtension {
         }
     }
 
+    /// Perform discovery of resources using the extension.
+    ///
+    /// # Returns
+    ///
+    /// A result containing a vector of discovered resources or an error.
+    ///
+    /// # Errors
+    ///
+    /// This function will return an error if the discovery fails.
     pub fn discover(&self) -> Result<Vec<DscResource>, DscError> {
         let mut resources: Vec<DscResource> = Vec::new();
 
@@ -97,11 +106,9 @@ impl DscExtension {
                         }
                     };
                     let manifest_path = Path::new(&discover_result.resource_manifest_path);
+                    // Currently we don't support extensions discovering other extensions
                     if let ManifestResource::Resource(resource) = load_manifest(manifest_path)? {
                         resources.push(resource);
-                    } else {
-                        // ignore loading other types of manifests
-                        continue;
                     }
                 }
             }