Skip to content

Conversation

@techalchemy
Copy link

Fix fsencode and fsdecode backports

Signed-off-by: Dan Ryan <dan@danryan.co>
- Mirrors the new python 3.7 implementation
- Taken from `vistir` (my other library) -> discussion over at
  sarugaku/vistir#54
- Fixes PiDelport#13
- Fixes PiDelport#6 (I think?)

Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
Signed-off-by: Dan Ryan <dan@danryan.co>
@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #16 into master will decrease coverage by 8.05%.
The diff coverage is 69.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   96.55%   88.49%   -8.06%     
==========================================
  Files           5        5              
  Lines         174      226      +52     
  Branches       27       32       +5     
==========================================
+ Hits          168      200      +32     
- Misses          2       20      +18     
- Partials        4        6       +2
Impacted Files Coverage Δ
tests/test_extra.py 85.18% <61.29%> (-14.82%) ⬇️
src/backports/os.py 86.66% <74.5%> (-7.01%) ⬇️
tests/test_helpers.py 100% <0%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45eda4e...a69d710. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failures on Windows Backport changes from Python 3.6

1 participant