Skip to content

AutoTarget Extension - Attack Non-Threatening Buildings #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

AutoTarget Extension - Attack Non-Threatening Buildings #1907

wants to merge 17 commits into from
+82 −2

Conversation

@Fly-Star-him
Copy link
Contributor

@Fly-Star-him Fly-Star-him commented Oct 11, 2025 •
edited
Loading

Players/AI can customize whether to attack non-threatening structures.
玩家/AI可以自定义能否攻击无威胁建筑。

@github-actions
Copy link

github-actions bot commented Oct 11, 2025 •
edited
Loading

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

CrimRecya
CrimRecya reviewed Oct 12, 2025
View reviewed changes
Copy link
Contributor

@CrimRecya CrimRecya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hooks are duplicated, they can be merged together

@Coronia Coronia requested a review from CrimRecya October 13, 2025 12:26
CrimRecya
CrimRecya requested changes Oct 13, 2025
View reviewed changes
Copy link
Contributor

@CrimRecya CrimRecya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect logical processing

@Coronia
Copy link
Contributor

Coronia commented Nov 14, 2025

could this be defined on buildings as well? In current game buildings will be auto targeted no matter if Insignificant set to true or false, so it would be better to have a separated tag for this purpose

@Fly-Star-him
Copy link
Contributor Author

Fly-Star-him commented Nov 14, 2025

could this be defined on buildings as well? In current game buildings will be auto targeted no matter if Insignificant set to true or false, so it would be better to have a separated tag for this purpose

If you need it, i can give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CrimRecya CrimRecya CrimRecya approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fly-Star-him @Coronia @CrimRecya