Revert weapon/WH detonate function optimization using shared bullet instance

Recursive detonation chains using features like DetonateOnAllMapObjects, ExtraWarheads, Crit etc. keep causing various issues with bullet properties being overwritten prematurely, impossible to cover for all cases which is why this needs to be reverted.

Author: Starkku

src/Ext/Bullet/Body.cpp

@@ -395,29 +395,12 @@ void BulletExt::ApplyArcingFix(BulletClass* pThis, const CoordStruct& sourceCoor
 	}
 }
 
-// Detonate weapon/warhead using master bullet instance.
+// Detonate weapon/warhead using a bullet.
 void BulletExt::Detonate(const CoordStruct& coords, TechnoClass* pOwner, int damage, HouseClass* pFiringHouse, AbstractClass* pTarget, bool isBright, WeaponTypeClass* pWeapon, WarheadTypeClass* pWarhead)
 {
-	auto pBullet = ScenarioExt::Global()->MasterDetonationBullet;
 	auto const pType = pWeapon ? pWeapon->Projectile : BulletTypeExt::GetDefaultBulletType();
-
-	// Oct 24, 2025 - Starkku: If the warhead is supposed to detonate on all map objects we actually need to create new BulletClass instance.
-	// Otherwise the master bullet instance can have its properties overwritten prematurely and cause weird issues.
-	if (WarheadTypeExt::ExtMap.Find(pWarhead)->DetonateOnAllMapObjects)
-	{
-		pBullet = pType->CreateBullet(pTarget, pOwner, damage, pWarhead, 100, isBright);
-		pBullet->WeaponType = pWeapon;
-	}
-	else
-	{
-		pBullet->Type = pType;
-		pBullet->WeaponType = pWeapon;
-		pBullet->Owner = pOwner;
-		pBullet->Health = damage;
-		pBullet->Target = pTarget;
-		pBullet->WH = pWarhead;
-		pBullet->Bright = isBright;
-	}
+	auto const pBullet = pType->CreateBullet(pTarget, pOwner, damage, pWarhead, 100, isBright);
+	pBullet->WeaponType = pWeapon;
 
 	auto const pBulletExt = BulletExt::ExtMap.Find(pBullet);
 	pBulletExt->IsInstantDetonation = true;
@@ -429,7 +412,6 @@ void BulletExt::Detonate(const CoordStruct& coords, TechnoClass* pOwner, int dam
 	pBullet->Explode(true);
 }
 
-
 // =============================
 // load / save
 

src/Ext/Rules/Body.cpp

@@ -1,4 +1,4 @@
-#include "Body.h"
+#include "Body.h"
 #include <Ext/Side/Body.h>
 #include <Utilities/TemplateDef.h>
 #include <FPSCounter.h>
@@ -389,9 +389,6 @@ void RulesExt::ExtData::InitializeAfterAllLoaded()
 	this->TintColorIronCurtain = GeneralUtils::GetColorFromColorAdd(pRules->IronCurtainColor);
 	this->TintColorForceShield = GeneralUtils::GetColorFromColorAdd(pRules->ForceShieldColor);
 	this->TintColorBerserk = GeneralUtils::GetColorFromColorAdd(pRules->BerserkColor);
-
-	// Init master bullet
-	ScenarioExt::Global()->MasterDetonationBullet = BulletTypeExt::GetDefaultBulletType()->CreateBullet(nullptr, nullptr, 0, nullptr, 0, false);
 }
 
 // =============================

src/Ext/Scenario/Body.cpp

@@ -167,7 +167,6 @@ void ScenarioExt::ExtData::Serialize(T& Stm)
 		.Process(this->DefaultLS640BkgdName)
 		.Process(this->DefaultLS800BkgdName)
 		.Process(this->DefaultLS800BkgdPal)
-		.Process(this->MasterDetonationBullet)
 		.Process(this->LimboLaunchers)
 		.Process(this->UndergroundTracker)
 		.Process(this->SpecialTracker)

src/Ext/Scenario/Body.h

@@ -46,7 +46,6 @@ class ScenarioExt
 		PhobosFixedString<64u> DefaultLS800BkgdName;
 		PhobosFixedString<64u> DefaultLS800BkgdPal;
 
-		BulletClass* MasterDetonationBullet; // Used to do warhead/weapon detonations on spot without having to create new BulletClass instance every time.
 		std::vector<TechnoExt::ExtData*> LimboLaunchers;
 
 		DynamicVectorClass<TechnoClass*> UndergroundTracker; // Technos that are underground.
@@ -66,7 +65,6 @@ class ScenarioExt
 			, DefaultLS640BkgdName {}
 			, DefaultLS800BkgdName {}
 			, DefaultLS800BkgdPal {}
-			, MasterDetonationBullet {}
 			, LimboLaunchers {}
 			, UndergroundTracker {}
 			, SpecialTracker {}