Fixed an issue that technos head to building's dock even they are not going to dock (#1863)

To test this fix:
1. set `[GAYARD] -> DockingOffset0=9999,0,0`
2. order an `[CARRIER]` to attack `[GAYARD]`
In vanilla, the hornets will head to the dock crd and be unable to fire.
With this fix, they should head to the shipyard itself and fire
normally.

Author: TaranDahl

CREDITS.md

@@ -618,6 +618,7 @@ This page lists all the individual contributions to the project by their author.
   - Fix an issue that jumpjet vehicles can not stop correctly when assigned a target in range
   - Fix an issue that jumpjet infantries stop incorrectly when assigned a target out of range
   - Fix an issue that jumpjet infantries' shadow is always drawn even if they are cloaked
+  - Fix an issue that technos head to building's dock even they are not going to dock
 - **solar-III (凤九歌)**
   - Target scanning delay customization (documentation)
   - Skip target scanning function calling for unarmed technos (documentation)

docs/Fixed-or-Improved-Logics.md

@@ -293,6 +293,7 @@ This page describes all ingame logics that are fixed or improved in Phobos witho
 - Fixed an issue that jumpjet vehicles can not stop correctly when assigned a target in range.
 - Fixed an issue that jumpjet infantries stop incorrectly when assigned a target out of range.
 - Fixed an issue that jumpjet infantries' shadow is always drawn even if they are cloaked.
+- Fixed an issue that technos head to building's dock even they are not going to dock.
 
 ```{note}
 The described behavior is a replica of and is compliant with XNA CnCNet Client's multiplayer save game support.

docs/Whats-New.md

@@ -474,6 +474,7 @@ Vanilla fixes:
 - Jumpjets in air now can correctly spawn missiles (by TaranDahl)
 - Fixed an issue that the currently hovered planning node not update up-to-date, such as using hotkeys to select technos (by CrimRecya)
 - Fixed an issue that jumpjet infantries' shadow is always drawn even if they are cloaked (by TaranDahl)
+- Fixed an issue that technos head to building's dock even they are not going to dock (by TaranDahl)
 
 Phobos fixes:
 - Fixed the bug that `AllowAirstrike=no` cannot completely prevent air strikes from being launched against it (by NetsuNegi)

src/Ext/Techno/Hooks.Misc.cpp

@@ -278,6 +278,15 @@ DEFINE_HOOK(0x4D962B, FootClass_SetDestination_RecycleFLH, 0x5)
 			*pDestCrd += TechnoExt::GetFLHAbsoluteCoords(pCarrier, FLH, pCarrierTypeExt->Spawner_RecycleOnTurret) - pCarrier->GetCoords();
 		}
 	}
+	else if (pThis->Destination->WhatAmI() == AbstractType::Building 
+		&& pThis->QueuedMission != Mission::Enter && pThis->GetCurrentMission() != Mission::Enter)
+	{
+		GET(CoordStruct*, pDestCrd, EAX);
+		auto crd = pThis->Destination->GetCoords();
+		crd.X = ((crd.X >> 8) << 8) + 128;
+		crd.Y = ((crd.Y >> 8) << 8) + 128;
+		*pDestCrd = crd;
+	}
 
 	return 0;
 }
@@ -845,4 +854,4 @@ DEFINE_HOOK(0x73D6E6, UnitClass_Unload_Subterranean, 0x6)
 	}
 
 	return 0;
-}
+}