Cleanup and add lifespan sync

Author: marvinbuss

code/function/fastapp/api/v1/endpoints/sample.py

@@ -3,11 +3,9 @@
 import httpx
 from fastapi import APIRouter, Header
 from fastapp.models.sample import SampleRequest, SampleResponse
-from fastapp.utils import setup_logging, setup_tracer
-from opentelemetry.trace import SpanKind
+from fastapp.utils import setup_logging
 
 logger = setup_logging(__name__)
-tracer = setup_tracer(__name__)
 
 router = APIRouter()
 
@@ -17,26 +15,11 @@ async def post_predict(
     data: SampleRequest, x_forwarded_for: Annotated[str, Header()] = ""
 ) -> SampleResponse:
     logger.info(f"Received request: {data}")
+    logger.info(f"IP of sender: {x_forwarded_for}")
 
     # Sample request
     async with httpx.AsyncClient() as client:
         response = await client.get("https://www.bing.com")
     logger.info(f"Received response status code: {response.status_code}")
 
-    # with httpx.Client() as client:
-    #     response = client.get("https://www.google.com")
-    # response = httpx.get("https://www.google.de")
-
-    # tracer_attributes = {"http.client_ip": x_forwarded_for}
-    # with tracer.start_as_current_span(
-    #     "dependency_span", attributes=tracer_attributes, kind=SpanKind.CLIENT
-    # ) as span:
-    #     try:
-    #         async with httpx.AsyncClient() as client:
-    #             response = await client.get("https://www.bing.com")
-    #         logger.info(f"Received response status code: {response.status_code}")
-    #     except Exception as ex:
-    #         span.set_attribute("status", "exception")
-    #         span.record_exception(ex)
-
     return SampleResponse(output=f"Hello {data.input}")

code/function/fastapp/main.py

@@ -14,6 +14,11 @@ async def lifespan(app: FastAPI) -> None:
     pass
 
 
+def lifespan_sync(app: FastAPI) -> None:
+    """Gracefully start the application before the server reports readiness."""
+    setup_opentelemetry(app=app)
+
+
 def get_app() -> FastAPI:
     """Setup the Fast API server.
 

code/function/wrapper/__init__.py

@@ -1,10 +1,9 @@
 import azure.functions as func
-from fastapp.main import app
-from fastapp.utils import setup_opentelemetry, setup_tracer
-from opentelemetry.context import attach, detach
+from fastapp.main import app, lifespan_sync
+from fastapp.utils import setup_tracer
 from opentelemetry.trace.propagation.tracecontext import TraceContextTextMapPropagator
 
-# setup_opentelemetry(app=app)
+lifespan_sync(app=app)
 tracer = setup_tracer(__name__)
 
 
@@ -24,12 +23,4 @@ async def main(req: func.HttpRequest, context: func.Context) -> func.HttpRespons
             req=req,  # context=parent_context
         )
 
-    # token = attach(parent_context)
-    # try:
-    #     with tracer.start_as_current_span("wrapper") as span:
-    #         response = await func.AsgiMiddleware(app).handle_async(req, parent_context)
-    # finally:
-    #     # End distributed tracing
-    #     detach(token)
-
     return response