Merge pull request #134 from timvaillancourt/mongodump_no_cmdline_passwd

1.0.2: Warn users if their password is on the mongodump command line (mongodump too old)

Author: timvaillancourt

mongodb_consistent_backup/Backup/Mongodump/Mongodump.py

@@ -47,7 +47,7 @@ def choose_compression(self):
             if self.compression() == 'auto':
                 logging.info("Mongodump binary supports gzip compression, auto-enabling gzip compression")
                 self.compression('gzip')
-	elif self.compression() == 'gzip':
+        elif self.compression() == 'gzip':
             raise OperationError("mongodump gzip compression requested on binary that does not support gzip!")
 
     def can_gzip(self):

mongodb_consistent_backup/Backup/Mongodump/MongodumpThread.py

@@ -116,6 +116,7 @@ def mongodump_cmd(self):
                 mongodump_flags.extend(["-u", self.user, "-p", '""'])
                 self.do_stdin_passwd = True
             else:
+                logging.warning("Mongodump is too old to set password securely! Upgrade to mongodump >= 3.2.0 to resolve this") 
                 mongodump_flags.extend(["-u", self.user, "-p", self.password])
         mongodump_cmd.extend(mongodump_flags)
         return mongodump_cmd