Added a function to validate hostname/IPs to prevent future issues like #54

Author: Tim Vaillancourt

MongoBackup/Backup.py

@@ -9,7 +9,7 @@
 from time import time
 
 from Archiver import Archiver
-from Common import DB, Lock
+from Common import DB, Lock, validate_hostname
 from Methods import Dumper
 from Notify import NotifyNSCA
 from Oplog import OplogTailer, OplogResolver
@@ -144,6 +144,7 @@ def __init__(self, options):
         #TODO should this be in init or a sub-function?
         # Get a DB connection
         try:
+            validate_hostname(self.host)
             self.db         = DB(self.host, self.port, self.user, self.password, self.authdb)
             self.connection = self.db.connection()
             self.is_sharded = self.connection.is_mongos

MongoBackup/Common/Util.py

@@ -0,0 +1,12 @@
+import logging
+import socket
+
+
+def validate_hostname(hostname):
+    try:
+        if ":" in hostname:
+            hostname, port = hostname.split(":")
+        socket.gethostbyname(hostname)
+    except socket.error, e:
+        logging.fatal("Could not resolve host '%s', error: %s" % (hostname, e))
+        raise Exception, "Could not resolve host '%s', error: %s" % (hostname, e), None

MongoBackup/Common/__init__.py

@@ -1,3 +1,4 @@
 from DB import DB
 from LocalCommand import LocalCommand
 from Lock import Lock
+from Util import validate_hostname

MongoBackup/Replset.py

@@ -2,7 +2,7 @@
 
 from math import ceil
 
-from Common import DB
+from Common import DB, validate_hostname
 
 
 class Replset:
@@ -66,6 +66,7 @@ def find_primary(self, force=False, quiet=False):
                     'host': member['name'],
                     'optime': optime_ts
                 }
+                validate_hostname(self.primary['host'])
                 logging.info("Found PRIMARY: %s/%s with optime %s" % (
                     rs_name,
                     member['name'],
@@ -115,6 +116,7 @@ def find_secondary(self, force=False, quiet=False):
                             'optime': optime_ts,
                             'score': score
                         }
+                        validate_hostname(self.secondary['host'])
                     log_msg = "Found SECONDARY %s/%s" % (rs_name, member['name'])
                 else:
                     log_msg = "Found SECONDARY %s/%s with too-high replication lag! Skipping" % (rs_name, member['name'])

MongoBackup/Sharding.py

@@ -2,7 +2,7 @@
 
 from time import sleep
 
-from Common import DB
+from Common import DB, validate_hostname
 from Replset import Replset
 
 
@@ -114,8 +114,12 @@ def get_configdb_hosts(self):
                 try:
                     if "/" in config_string:
                         config_replset, config_string = config_string.split("/")
-                    return config_string.split(',')
+                    config_hosts = config_string.split(',')
+                    for config_host in config_hosts:
+                        validate_hostname(hostname)
+                    return config_hosts
                 except Exception:
+                    validate_hostname(config_string) 
                     return [config_string]
             else:
                 logging.fatal("Unable to locate config servers for %s:%i!" % (self.db.host, self.db.port))