Skip to content

Commit 93900f1

Browse files
Merge pull request #88 from timvaillancourt/MCB_1.0-cleanup_v5
Mcb 1.0 cleanup v5
2 parents a9b008e + 5de7948 commit 93900f1

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

mongodb_consistent_backup/Main.py

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ def __init__(self, prog_name="mongodb-consistent-backup"):
3535
self.backup_time = None
3636
self.backup_root_directory = None
3737
self.backup_root_subdirectory = None
38-
self.connection = None
3938
self.db = None
4039
self.is_sharded = False
4140
self.secondaries = {}
@@ -44,8 +43,8 @@ def __init__(self, prog_name="mongodb-consistent-backup"):
4443
self.log_level = None
4544

4645
self.setup_config()
47-
self.setup_signal_handlers()
4846
self.setup_logger()
47+
self.setup_signal_handlers()
4948
self.set_backup_dirs()
5049
self.get_db_conn()
5150

@@ -68,8 +67,7 @@ def setup_signal_handlers(self):
6867
signal(SIGINT, self.cleanup_and_exit)
6968
signal(SIGTERM, self.cleanup_and_exit)
7069
except Exception, e:
71-
# TODO-timv Where is logger coming from?
72-
logger.fatal("Cannot setup signal handlers, error: %s" % e)
70+
logging.fatal("Cannot setup signal handlers, error: %s" % e)
7371
sys.exit(1)
7472

7573
def set_backup_dirs(self):
@@ -81,8 +79,7 @@ def get_db_conn(self):
8179
try:
8280
validate_hostname(self.config.host)
8381
self.db = DB(self.config.host, self.config.port, self.config.user, self.config.password, self.config.authdb)
84-
self.connection = self.db.connection()
85-
self.is_sharded = self.connection.is_mongos
82+
self.is_sharded = self.db.connection().is_mongos
8683
except Exception, e:
8784
raise e
8885

0 commit comments

Comments
 (0)