Merge pull request #43 from timvaillancourt/pycharm_warn_fix

Pycharm warn fix

Author: dbmurphy

MongoBackup/Oplog/Resolver.py

@@ -27,6 +27,7 @@ def __init__(self, tailed_oplogs_summary, backup_oplogs_summary, dump_gzip=False
         self.thread_count  = thread_count
 
         self.end_ts = None
+        self.delete_oplogs = {}
 
         if self.thread_count is None:
             self.thread_count = cpu_count() * 2
@@ -50,18 +51,17 @@ def get_consistent_end_ts(self):
     def run(self):
         logging.info("Resolving oplogs using %i threads max" % self.thread_count)
 
-        tailed_oplogs = []
         self.end_ts   = self.get_consistent_end_ts()
         for host in self.backup_oplogs:
             for port in self.backup_oplogs[host]:
                 backup_oplog = self.backup_oplogs[host][port]
                 if host in self.tailed_oplogs and port in self.tailed_oplogs[host]:
                     tailed_oplog = self.tailed_oplogs[host][port]
-                    tailed_oplogs.append({
+                    tailed_oplog_file = tailed_oplog['file']
+                    self.delete_oplogs[tailed_oplog_file] = {
                         'host': host,
-                        'port': port,
-                        'file': tailed_oplog['file']
-                    })
+                        'port': port
+                    }
 
                     if backup_oplog['last_ts'] is None and tailed_oplog['last_ts'] is None:
                         logging.info("No oplog changes to resolve for %s:%s" % (host, port))
@@ -88,10 +88,13 @@ def run(self):
         self._pool.close()
         self._pool.join()
 
-        for oplog_file in tailed_oplogs:
+        for oplog_file in self.delete_oplogs:
             try:
-                logging.debug("Deleting tailed oplog file for %s:%s" % (oplog_file['host'], oplog_file['port']))
-                os.remove(oplog_file['file'])
+                logging.debug("Deleting tailed oplog file for %s:%i" % (
+                    self.delete_oplogs[oplog_file]['host'],
+                    self.delete_oplogs[oplog_file]['port']
+                ))
+                os.remove(oplog_file)
             except Exception, e:
                 logging.fatal("Deleting of tailed oplog file %s failed! Error: %s" % (oplog_file, e))
                 raise e