Make shared func for parsing config bools

Author: timvaillancourt

mongodb_consistent_backup/Backup/Mongodump/MongodumpThread.py

@@ -8,7 +8,7 @@
 from signal import signal, SIGINT, SIGTERM, SIG_IGN
 from subprocess import Popen, PIPE
 
-from mongodb_consistent_backup.Common import is_datetime
+from mongodb_consistent_backup.Common import is_datetime, parse_config_bool
 from mongodb_consistent_backup.Oplog import Oplog
 
 
@@ -58,11 +58,10 @@ def close(self, exit_code=None, frame=None):
         sys.exit(self.exit_code)
 
     def do_ssl(self):
-        if isinstance(self.ssl_enabled, bool):
-            return self.ssl_enabled
-        elif isinstance(self.ssl_enabled, str) and self.ssl_enabled.rstrip().lower() is "true":
-            return True
-        return False
+        return parse_config_bool(self.ssl_enabled)
+
+    def do_ssl_insecure(self):
+        return parse_config_bool(self.ssl_insecure)
 
     def parse_mongodump_line(self, line):
         try:
@@ -153,7 +152,7 @@ def mongodump_cmd(self):
                 mongodump_flags.extend(["--sslCRLFile", self.ssl_crl_file])
             if self.client_cert_file:
                 mongodump_flags.extend(["--sslPEMKeyFile", self.ssl_cert_file])
-            if self.ssl_insecure:
+            if self.do_ssl_insecure():
                 mongodump_flags.extend(["--sslAllowInvalidCertificates", "--sslAllowInvalidHostnames"])
         mongodump_cmd.extend(mongodump_flags)
         return mongodump_cmd

mongodb_consistent_backup/Common/Config.py

@@ -8,6 +8,18 @@
 from yconf.util import NestedDict
 
 
+def parse_config_bool(item):
+    try:
+        if isinstance(item, bool):
+            return item
+        elif isinstance(item, str):
+            if item.rstrip().lower() is "true":
+                return True
+    except:
+        return False
+    return False
+
+
 class PrintVersions(Action):
     def __init__(self, option_strings, dest, nargs=0, **kwargs):
         super(PrintVersions, self).__init__(option_strings=option_strings, dest=dest, nargs=nargs, **kwargs)

mongodb_consistent_backup/Common/DB.py

@@ -7,6 +7,7 @@
 from ssl import CERT_REQUIRED, CERT_NONE
 from time import sleep
 
+from mongodb_consistent_backup.Common import parse_config_bool
 from mongodb_consistent_backup.Errors import DBAuthenticationError, DBConnectionError, DBOperationError, Error
 
 
@@ -37,11 +38,10 @@ def __init__(self, uri, config, do_replset=False, read_pref='primaryPreferred',
         self.auth_if_required()
 
     def do_ssl(self):
-        if isinstance(self.ssl_enabled, bool):
-            return self.ssl_enabled
-        elif isinstance(self.ssl_enabled, str) and self.ssl_enabled.rstrip().lower() is "true":
-            return True
-        return False
+        return parse_config_bool(self.ssl_enabled)
+
+    def do_ssl_insecure(self):
+        return parse_config_bool(self.ssl_insecure)
 
     def client_opts(self):
         opts = {
@@ -67,7 +67,7 @@ def client_opts(self):
                 "ssl_certfile":  self.ssl_client_cert_file,
                 "ssl_cert_reqs": CERT_REQUIRED,
             })
-            if self.ssl_insecure:
+            if self.do_ssl_insecure():
                 opts["ssl_cert_reqs"] = CERT_NONE
         return opts
 

mongodb_consistent_backup/Common/__init__.py

@@ -1,4 +1,4 @@
-from Config import Config  # NOQA
+from Config import Config, parse_config_bool  # NOQA
 from DB import DB  # NOQA
 from LocalCommand import LocalCommand  # NOQA
 from Lock import Lock  # NOQA