Fixed issue in nullspace_linear_elasticity

Author: fverdugo

src/PartitionedArrays.jl

@@ -180,7 +180,8 @@ include("p_timer.jl")
 export laplacian_fdm
 export laplacian_fem
 export linear_elasticity_fem
-export node_coorinates_unit_cube
+export node_coordinates_unit_cube
+export nullspace_linear_elasticity
 export near_nullspace_linear_elasticity
 include("gallery.jl")
 

src/gallery.jl

@@ -415,12 +415,12 @@ function node_to_dof_partition(node_partition,D)
     dof_partition
 end
 
-function node_coorinates_unit_cube(
+function node_coordinates_unit_cube(
         nodes_per_dir, # free (== interior) nodes
         parts_per_dir,
         parts,
         ;
-        split_format = Val(true),
+        split_format = Val(false),
         value_type::Type{Tv} = Float64,) where Tv
 
     function setup!(own_x,mynodes)
@@ -443,7 +443,12 @@ function node_coorinates_unit_cube(
     x
 end
 
-function near_nullspace_linear_elasticity(x,
+function near_nullspace_linear_elasticity(a...;b...)
+    @warn "near_nullspace_linear_elasticity is deprecated, use nullspace_linear_elasticity instead"
+    nullspace_linear_elasticity(a...;b...)
+end
+
+function nullspace_linear_elasticity(x,
         row_partition = node_to_dof_partition(partition(axes(x,1)),length(eltype(x)))
     )
     T = eltype(x)
@@ -461,10 +466,10 @@ function near_nullspace_linear_elasticity(x,
     dof_partition = row_partition
     split_format = Val(eltype(partition(x)) <: SplitVector)
     B = [ pzeros(Tv,dof_partition;split_format) for _ in 1:nb ]
-    near_nullspace_linear_elasticity!(B,x)
+    nullspace_linear_elasticity!(B,x)
 end
 
-function near_nullspace_linear_elasticity!(B,x)
+function nullspace_linear_elasticity!(B,x)
     D = length(eltype(x))
     if D == 1
         foreach(own_values(B[1])) do own_b

test/gallery_tests.jl

@@ -32,20 +32,26 @@ function gallery_tests(distribute,parts_per_dir)
     @test isa(y,PVector)
     A = psparse(SparseMatrixCSR{1,Float64,Int32},args...) |> fetch
     A |> centralize |> display
-    Y = A*pones(axes(A,2))
+    y = A*pones(axes(A,2))
     @test isa(y,PVector)
 
     args = linear_elasticity_fem(nodes_per_dir,parts_per_dir,ranks)
     A = psparse(args...) |> fetch
     A |> centralize |> display
-    Y = A*pones(axes(A,2))
+    y = A*pones(axes(A,2))
     @test isa(y,PVector)
 
-    x = node_coorinates_unit_cube(nodes_per_dir,parts_per_dir,ranks)
-    B = near_nullspace_linear_elasticity(x)
+    x = node_coordinates_unit_cube(nodes_per_dir,parts_per_dir,ranks)
+    B = nullspace_linear_elasticity(x)
     @test isa(B[1],PVector)
-    B = near_nullspace_linear_elasticity(x,partition(axes(A,2)))
+    y = A*pones(axes(A,2))
+    @test isa(y,PVector)
+    B = nullspace_linear_elasticity(x,partition(axes(A,2)))
     @test isa(B[1],PVector)
+    y = A*pones(axes(A,2))
+    @test isa(Y,PVector)
+    y = A*B[1]
+    @test isa(y,PVector)
 
 end