Bugfix in pvector!

Author: fverdugo

src/p_vector.jl

@@ -598,7 +598,7 @@ function pvector(f,I,V,rows;
         map(map_local_to_global!,I,rows_sa)
     end
     A = PVector(values_sa,rows_sa)
-    if assemble
+    if !assembled && assemble
         t = PartitionedArrays.assemble(A,rows;reuse=true)
     else
         t = @async A,nothing
@@ -631,7 +631,7 @@ function pvector!(B,V,cache)
     rows_sa = partition(axes(A,1))
     values_sa = partition(A)
     map(update!,values_sa,K,V)
-    if !assembled && assembled
+    if !assembled && assemble
         t = PartitionedArrays.assemble!(B,A,cacheB)
     else
         t = @async B
@@ -964,7 +964,7 @@ function assemble!(w::PVector,v::PVector,cache)
     # for the moment.
     # The construction of v2 can (should) be avoided
     v2 = cache
-    map(copy!,local_values(v2),local_values(v))
+    copy!(v2,v)
     t = assemble!(v2)
     @async begin
         wait(t)

test/fem_example.jl

@@ -318,7 +318,14 @@ function fem_example(distribute)
     x = IterativeSolvers.cg(A,b,verbose=i_am_main(rank))
     @test norm(x-x̂) < 1.0e-5
 
-    psystem!(A,b,V,VV,cache) |> fetch
+    ## Re assembly with different values
+    V2 = map(i->2*i,V)
+    VV2 = map(i->2*i,VV)
+    #display(partition(b))
+    psystem!(A,b,V2,VV2,cache) |> wait
+    #display(partition(b))
+    x = IterativeSolvers.cg(A,b,verbose=i_am_main(rank))
+    @test norm(x-x̂) < 1.0e-5
 
     # Sub-assembled variant
     A,b = psystem(I,J,V,II,VV,dof_partition,dof_partition;assemble=false) |> fetch