Fixed forward agent flag not applying from native parallel client, added test for it.

Updated changelog.

Author: Pan

.travis.yml

@@ -52,7 +52,7 @@ jobs:
         - PYENV: 3.6.4
       before_install:
         - brew update
-        - brew outdated openssl || brew upgrade openssl
+        - brew outdated openssl || brew upgrade openssl || echo "y"
         - brew link --overwrite python@2 || brew install python@2 || brew link --overwrite python@2
         - which python2
         - python2 -c "from __future__ import print_function; import ssl; from platform import python_version; print(ssl.OPENSSL_VERSION); print(python_version())"

Changelog.rst

@@ -1,6 +1,14 @@
 Change Log
 ============
 
+1.8.2
+++++++
+
+Fixes
+------
+
+* Native parallel client ``forward_ssh_agent`` flag would not be applied correctly.
+
 1.8.1
 ++++++
 

pssh/clients/native/parallel.py

@@ -379,7 +379,8 @@ def _make_ssh_client(self, host):
                     pkey=_pkey, num_retries=self.num_retries,
                     timeout=self.timeout,
                     allow_agent=self.allow_agent, retry_delay=self.retry_delay,
-                    proxy_host=proxy_host, _auth_thread_pool=auth_thread_pool)
+                    proxy_host=proxy_host, _auth_thread_pool=auth_thread_pool,
+                    forward_ssh_agent=self.forward_ssh_agent)
 
     def copy_file(self, local_file, remote_file, recurse=False, copy_args=None):
         """Copy local file to remote file in parallel

tests/test_native_parallel_client.py

@@ -1393,3 +1393,11 @@ def test_scp_recv(self):
     def test_bad_hosts_value(self):
         self.assertRaises(TypeError, ParallelSSHClient, 'a host')
         self.assertRaises(TypeError, ParallelSSHClient, b'a host')
+
+    def test_disable_agent_forward(self):
+        client = ParallelSSHClient(
+            [self.host], port=self.port, pkey=self.user_key,
+            forward_ssh_agent=False,
+            num_retries=1)
+        client.join(client.run_command(self.cmd))
+        self.assertFalse(client.host_clients[self.host].forward_ssh_agent)