Added unit test for running cmd without shell. Updated documentation. More sleeps to avoid race condition in proxy test

Author: Dan

pssh/pssh_client.py

@@ -249,8 +249,9 @@ def run_command(self, *args, **kwargs):
         Defaults to True. With stop_on_errors set to False, exceptions are instead \
         added to output of `run_command`. See example usage below.
         :type stop_on_errors: bool
-        :param kwargs: Keyword arguments for command
-        :type kwargs: dict
+        :param use_shell: (Optional) Run command with or without shell. Defaults \
+        to True - use shell defined in user login to run command string
+        :type use_shell: bool
         :rtype: Dictionary with host as key as per \
           :mod:`pssh.pssh_client.ParallelSSHClient.get_output`
         

tests/test_pssh_client.py

@@ -472,6 +472,7 @@ def test_ssh_proxy(self):
         proxy_server_socket = make_socket('127.0.0.2')
         proxy_server_port = proxy_server_socket.getsockname()[1]
         proxy_server = start_server(proxy_server_socket)
+        gevent.sleep(2)
         client = ParallelSSHClient([self.host], port=self.listen_port,
                                    pkey=self.user_key,
                                    proxy_host='127.0.0.2',

tests/test_ssh_client.py

@@ -247,5 +247,30 @@ def test_ssh_client_pty(self):
         del channel
         del client
 
+    def test_ssh_client_pty(self):
+        """Test that running command sans shell works as expected
+        and that shell commands fail accordingly"""
+        client = SSHClient(self.host, port=self.listen_port,
+                           pkey=self.user_key)
+        channel, host, stdout, stderr = client.exec_command(self.fake_cmd, use_shell=False)
+        output = list(stdout)
+        stderr = list(stderr)
+        expected = []
+        exit_code = channel.recv_exit_status()
+        self.assertEqual(expected, output,
+                         msg = "Got unexpected command output - %s" % (output,))
+        self.assertTrue(exit_code==127,
+                        msg="Expected cmd not found error code 127, got %s instead" % (
+                            exit_code,))
+        channel, host, stdout, stderr = client.exec_command('id', use_shell=False)
+        output = list(stdout)
+        exit_code = channel.recv_exit_status()
+        self.assertTrue(output,
+                        msg="Got no output from cmd executed without shell")
+        self.assertTrue(exit_code==0,
+                        msg="Cmd executed with shell failed with error code %s" % (
+                            exit_code,))
+        del client
+
 if __name__ == '__main__':
     unittest.main()