-
Notifications
You must be signed in to change notification settings - Fork 4
🎉 feature(storage) Add multiple storage backends #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
casenave
wants to merge
33
commits into
main
Choose a base branch
from
storage
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ample) add string support to globals
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Implemented a facotrization of function needed for all backends and refactored the HF_datasets backend while added an additional zarr backend.
The webdataset backend is not provided yet, since there are some unexpected difficulties ocurring when trying to set one tar per feature per sample: iterating over the dataset will not enable easily to group files per sample - must find an efiicient trick, maybe by storing a dict with key the sample id and value the list of tar files corresponding to the sample ? Will this be efficient for iteration and plaid sample reconstruction ?
Implemented:
download_datasetfor hf_dataset storage mode #278)Tests, examples and tutorials to come
🔗 Related issues
Closes #270, #277