added tests for exception conversion into appropriate http responses

Author: Raaghu

src/RESTFul/Routing/Route.php

@@ -86,6 +86,7 @@ static function run($uri = null){
 		}catch (HttpException $h){
 			$body = $h->getBody();
 			if($h instanceof InternalServerError){
+				new ProgrammingError($body); // for logging purpose
 				$body = null;
 			}
 			$httpResponse = new HTTPResponse($h->getCode(),$h->getMessage(),$body);

tests/RESTFul/ClientSide/TestRoute.php

@@ -85,6 +85,27 @@ function testExceptionFromServiceMethod(){
 		$client = new Client();
 		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/exception');
 
+		$isException = false;
+		try{
+			$client->send($request);
+		}catch (ServerErrorResponseException $e){
+			$response = $e->getResponse();
+			$this->assertEquals(500, $response->getStatusCode());
+			$this->assertEquals("Internal Server Error", $response->getReasonPhrase());
+			$this->assertEquals("", $response->getBody(true));
+			
+			// validate log
+			$this->assertContainsAndClearLog('Testing Exception in Service Method');
+			
+			$isException = true;
+		}
+		$this->assertTrue($isException);
+	}
+	
+	function testPlatformExceptionFromServiceMethod(){
+		$client = new Client();
+		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/exception/platform-exception');
+		
 		$isException = false;
 		try{
 			$client->send($request);
@@ -102,6 +123,69 @@ function testExceptionFromServiceMethod(){
 		$this->assertTrue($isException);
 	}
 
+	function testInternalServerErrorFromServiceMethod(){
+		$client = new Client();
+		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/exception/internal-server-error');
+		
+		$isException = false;
+		try{
+			$client->send($request);
+		}catch (ServerErrorResponseException $e){
+			$response = $e->getResponse();
+			$this->assertEquals(500, $response->getStatusCode());
+			$this->assertEquals("Internal Server Error", $response->getReasonPhrase());
+			$this->assertEquals("", $response->getBody(true));
+			
+			// validate log
+			$this->assertContainsAndClearLog('Testing Uncaught internalServerError in Service');
+			
+			$isException = true;
+		}
+		$this->assertTrue($isException);
+	}
+	
+	function testDataNotFoundExceptionFromServiceMethod(){
+		$client = new Client();
+		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/exception/data-not-found-exception');
+		
+		$isException = false;
+		try{
+			$client->send($request);
+		}catch (ClientErrorResponseException $e){
+			$response = $e->getResponse();
+			$this->assertEquals(404, $response->getStatusCode());
+			$this->assertEquals("Not Found", $response->getReasonPhrase());
+			$this->assertEquals("", $response->getBody(true));
+			
+			// validate log
+			$this->assertContainsAndClearLog('[H][404][::1][/test/route/exception/data-not-found-exception] Not Found');
+			
+			$isException = true;
+		}
+		$this->assertTrue($isException);
+	}
+	
+	function testNoAccessExceptionFromServiceMethod(){
+		$client = new Client();
+		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/exception/no-access-exception');
+		
+		$isException = false;
+		try{
+			$client->send($request);
+		}catch (ClientErrorResponseException $e){
+			$response = $e->getResponse();
+			$this->assertEquals(401, $response->getStatusCode());
+			$this->assertEquals("Unauthorized", $response->getReasonPhrase());
+			$this->assertEquals("", $response->getBody(true));
+			
+			// validate log
+			$this->assertContainsAndClearLog('[H][401][::1][/test/route/exception/no-access-exception] Unauthorized');
+			
+			$isException = true;
+		}
+		$this->assertTrue($isException);
+	}
+	
 	function testPathParams(){
 		$client = new Client();
 		$request = $client->get(APP_DOMAIN.'/'.APP_PATH.'/test/route/myParam1/path/myParam2');

tests/RESTFul/Services/TestRoute.php

@@ -6,6 +6,9 @@
 use PhpPlatform\RESTFul\HTTPResponse;
 use PhpPlatform\Errors\Exceptions\Application\BadInputException;
 use PhpPlatform\RESTFul\HTTPRequest;
+use PhpPlatform\Errors\Exceptions\Http\_5XX\InternalServerError;
+use PhpPlatform\Errors\Exceptions\Persistence\DataNotFoundException;
+use PhpPlatform\Errors\Exceptions\Persistence\NoAccessException;
 
 /**
  * @Path "/test/route"
@@ -45,12 +48,46 @@ function wrongResponse(){
 		return array("this"=>array("is","JSON","from","array"));
 	}
 
+	/**
+	 * @Path "/exception/platform-exception"
+	 * @GET
+	 */
+	function platformException(){
+		throw new BadInputException("Testing Uncaught Bad Input Exception in Service");
+	}
+	
+	/**
+	 * @Path "/exception/internal-server-error"
+	 * @GET
+	 */
+	function internalServerError(){
+		throw new InternalServerError("Testing Uncaught internalServerError in Service");
+	}
+	
+	/**
+	 * @Path "/exception/data-not-found-exception"
+	 * @GET
+	 */
+	function dataNotFoundException(){
+		throw new DataNotFoundException();
+	}
+	
+	
+	/**
+	 * @Path "/exception/no-access-exception"
+	 * @GET
+	 */
+	function noAccessException(){
+		throw new NoAccessException();
+	}
+	
+	
 	/**
 	 * @Path "/exception"
 	 * @GET
 	 */
 	function exception(){
-		throw new BadInputException("Testing Uncaught Bad Input Exception in Service");
+		throw new \Exception("Testing Exception in Service Method");
 	}
 
 	/**
@@ -119,4 +156,5 @@ function testHTTPMethodDELETE($request){
 	function testHTTPMethodDefault($request){
 		return new HTTPResponse(200,'OK',"Default");
 	}
+
 }