Minor Tweaks

Author: oleibman

docs/topics/Excel Anomalies.md

@@ -15,6 +15,7 @@ If you have a spreadsheet that has been altered in this way, it can be fixed wit
 ```php
         foreach ($spreadsheet->getCellXfCollection() as $style) {
             $numberFormat = $style->getNumberFormat();
+            // okay to use NumberFormat::SHORT_DATE_INDEX below
             if ($numberFormat->getBuiltInFormatCode() === 14) {
                 $numberFormat->setFormatCode('yyyy-mm-dd');
             }
@@ -23,7 +24,7 @@ If you have a spreadsheet that has been altered in this way, it can be fixed wit
 Starting with PhpSpreadsheet 4.5.0, this can be simplified to:
 ```php
         $spreadsheet->replaceBuiltinNumberFormat(
-            14,
+            \PhpOffice\PhpSpreadsheet\Style\NumberFormat::SHORT_DATE_INDEX,
             'yyyy-mm-dd'
         );
 ```

tests/PhpSpreadsheetTests/Reader/Xlsx/ReplaceBuiltinNumberFormatTest.php

@@ -5,6 +5,7 @@
 namespace PhpOffice\PhpSpreadsheetTests\Reader\Xlsx;
 
 use PhpOffice\PhpSpreadsheet\Spreadsheet;
+use PhpOffice\PhpSpreadsheet\Style\NumberFormat;
 use PhpOffice\PhpSpreadsheetTests\Functional\AbstractFunctional;
 
 class ReplaceBuiltinNumberFormatTest extends AbstractFunctional
@@ -25,17 +26,17 @@ protected function tearDown(): void
         }
     }
 
-    public function testJustifyLastLine(): void
+    public function testReplaceBuiltinNumberFormat(): void
     {
         $spreadsheet = $this->spreadsheet = new Spreadsheet();
         $sheet = $this->spreadsheet->getActiveSheet();
         $sheet->fromArray([45486, 1023, 45487, 45488, 45489]);
         $sheet->getStyle('A1')->getNumberFormat()
-            ->setBuiltInFormatCode(14);
+            ->setBuiltInFormatCode(NumberFormat::SHORT_DATE_INDEX);
         $sheet->getStyle('B1')->getNumberFormat()
             ->setFormatCode('#,##0.00');
         $sheet->getStyle('C1')->getNumberFormat()
-            ->setBuiltInFormatCode(14);
+            ->setBuiltInFormatCode(NumberFormat::SHORT_DATE_INDEX);
         $sheet->getStyle('D1')->getNumberFormat()
             ->setFormatCode('dd-MMM-yyyy');
         $sheet->getStyle('E1')->getNumberFormat()
@@ -51,7 +52,7 @@ public function testJustifyLastLine(): void
         self::assertSame($expected, $values);
         $this->reloadedSpreadsheet = $this->writeAndReload($spreadsheet, 'Xlsx');
         $this->reloadedSpreadsheet->replaceBuiltinNumberFormat(
-            14,
+            NumberFormat::SHORT_DATE_INDEX,
             'yyyy-mm-dd'
         );
         $rsheet = $this->reloadedSpreadsheet->getActiveSheet();