Squiz/EmbeddedPhp: bug fix - open tag on own line intended indent calculation

Basically, this is the same bug as fixed in a previous commit for the intended content indent calculation.
The indentation of the first token in the file would be used to calculate the intended indentation, instead of the indentation for the first token on the line containing the PHP open tag.

Fixed now, includes test.

Note: The only reason the test doesn't actually show the bug is because of the earlier "fixer adds stray new line" bugfix in this PR, which means that the fixer for the previous close tag will prevent the buggy fixer from running.
Without _that_ fix, this bug would be visible when running with `-vvv` (indent would get set to 32 and then corrected to 4 on the next fixer round via the `OpenTagIndent` fixer).

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/EmbeddedPhpSniff.php

@@ -185,10 +185,13 @@ private function validateMultilineEmbeddedPhp($phpcsFile, $stackPtr, $closingTag
             $error = 'Opening PHP tag must be on a line by itself';
             $fix   = $phpcsFile->addFixableError($error, $stackPtr, 'ContentBeforeOpen');
             if ($fix === true) {
-                $first = $phpcsFile->findFirstOnLine(T_WHITESPACE, $stackPtr);
+                $padding = 0;
+                $first   = $phpcsFile->findFirstOnLine(T_WHITESPACE, $stackPtr);
                 if ($first === false) {
-                    $first   = $phpcsFile->findFirstOnLine(T_INLINE_HTML, $stackPtr);
-                    $padding = (strlen($tokens[$first]['content']) - strlen(ltrim($tokens[$first]['content'])));
+                    $first = $phpcsFile->findFirstOnLine(T_INLINE_HTML, $stackPtr);
+                    if ($first !== false) {
+                        $padding = (strlen($tokens[$first]['content']) - strlen(ltrim($tokens[$first]['content'])));
+                    }
                 } else {
                     $padding = ($tokens[($first + 1)]['column'] - 1);
                 }

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.22.inc

@@ -14,6 +14,16 @@ echo 'indent is correct - first on line for open tag is open tag';
        echo 'indent is incorrect - first on line for open tag is inline HTML';
 ?>
 
+<!--
+Open tag indent calculation should not look at first token in the stack, but only at the line containing the PHP open tag for the block.
+-->
+<?php
+// This is only here so we can have a close tag as the first token on the next line.
+?><?php
+// The PHP open tag should be fixed to be at the very start of the line without indent.
+// And the indent of this comment should be seen as correct.
+?>
+
 <?php
 // This test case file MUST always end with an unclosed long open PHP tag (with this comment) to prevent
 // the tests running into the "last PHP closing tag excepted" condition breaking tests.

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.22.inc.fixed

@@ -14,6 +14,17 @@ echo 'indent is correct - first on line for open tag is open tag';
 echo 'indent is incorrect - first on line for open tag is inline HTML';
 ?>
 
+<!--
+Open tag indent calculation should not look at first token in the stack, but only at the line containing the PHP open tag for the block.
+-->
+<?php
+// This is only here so we can have a close tag as the first token on the next line.
+?>
+<?php
+// The PHP open tag should be fixed to be at the very start of the line without indent.
+// And the indent of this comment should be seen as correct.
+?>
+
 <?php
 // This test case file MUST always end with an unclosed long open PHP tag (with this comment) to prevent
 // the tests running into the "last PHP closing tag excepted" condition breaking tests.

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.php

@@ -178,7 +178,10 @@ public function getErrorList($testFile='')
             return [12 => 2];
 
         case 'EmbeddedPhpUnitTest.22.inc':
-            return [14 => 1];
+            return [
+                14 => 1,
+                22 => 2,
+            ];
 
         default:
             return [];