Generic/UnnecessaryFinalModifier: add tests for final class constants

Author: rodrigoprimo

src/Standards/Generic/Tests/CodeAnalysis/UnnecessaryFinalModifierUnitTest.1.inc

@@ -32,3 +32,25 @@ final readonly class Foo_Bar {
     public final function fooBar() {}
     final protected function fool() {}
 }
+
+final class Final_Class_Final_Constants {
+    final public const FINAL_PUBLIC_CONST = 23;
+    protected final const FINAL_PROTECTED_CONST = 'foo';
+}
+
+final class Final_Class_Regular_Constants {
+    public const PUBLIC_CONST = 23;
+    protected const PROTECTED_CONST = 'foo';
+    private const PRIVATE_CONST = true;
+}
+
+class Regular_Class_Final_Constants {
+    public final const FINAL_PUBLIC_CONST = 23;
+    final protected const FINAL_PROTECTED_CONST = 'foo';
+}
+
+class Regular_Class_Regular_Constants {
+    public const PUBLIC_CONST = 23;
+    protected const PROTECTED_CONST = 'foo';
+    private const PRIVATE_CONST = true;
+}

src/Standards/Generic/Tests/CodeAnalysis/UnnecessaryFinalModifierUnitTest.php

@@ -56,6 +56,8 @@ public function getWarningList($testFile='')
                 18 => 1,
                 32 => 1,
                 33 => 1,
+                37 => 1,
+                38 => 1,
             ];
         default:
             return [];