Tests/BackfillReadonlyTest: simplify data providers

The token content for the "target token" of these tests is the same in most cases, but was explicitly provided in all cases.

This simplifies the data provider arrays by making the `$testContent` test parameters optional with a `'readonly'` default value, allowing for removing a significant number of the `$testContent` parameter values from the data providers.

Author: jrfnl

tests/Core/Tokenizer/BackfillReadonlyTest.php

@@ -19,14 +19,15 @@ final class BackfillReadonlyTest extends AbstractMethodUnitTest
      * Test that the "readonly" keyword is tokenized as such.
      *
      * @param string $testMarker  The comment which prefaces the target token in the test file.
-     * @param string $testContent The token content to look for.
+     * @param string $testContent Optional. The token content to look for.
+     *                            Defaults to lowercase "readonly".
      *
      * @dataProvider dataReadonly
      * @covers       PHP_CodeSniffer\Tokenizers\PHP::processAdditional
      *
      * @return void
      */
-    public function testReadonly($testMarker, $testContent)
+    public function testReadonly($testMarker, $testContent='readonly')
     {
         $tokens = self::$phpcsFile->getTokens();
 
@@ -49,143 +50,110 @@ public static function dataReadonly()
         return [
             [
                 '/* testReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testVarReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testReadonlyVarProperty */',
-                'readonly',
             ],
             [
                 '/* testStaticReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testReadonlyStaticProperty */',
-                'readonly',
             ],
             [
                 '/* testConstReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyWithoutType */',
-                'readonly',
             ],
             [
                 '/* testPublicReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testProtectedReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testPrivateReadonlyProperty */',
-                'readonly',
             ],
             [
                 '/* testPublicReadonlyPropertyWithReadonlyFirst */',
-                'readonly',
             ],
             [
                 '/* testProtectedReadonlyPropertyWithReadonlyFirst */',
-                'readonly',
             ],
             [
                 '/* testPrivateReadonlyPropertyWithReadonlyFirst */',
-                'readonly',
             ],
             [
                 '/* testReadonlyWithCommentsInDeclaration */',
-                'readonly',
             ],
             [
                 '/* testReadonlyWithNullableProperty */',
-                'readonly',
             ],
             [
                 '/* testReadonlyNullablePropertyWithUnionTypeHintAndNullFirst */',
-                'readonly',
             ],
             [
                 '/* testReadonlyNullablePropertyWithUnionTypeHintAndNullLast */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyWithArrayTypeHint */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyWithSelfTypeHint */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyWithParentTypeHint */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyWithFullyQualifiedTypeHint */',
-                'readonly',
             ],
             [
                 '/* testReadonlyIsCaseInsensitive */',
                 'ReAdOnLy',
             ],
             [
                 '/* testReadonlyConstructorPropertyPromotion */',
-                'readonly',
             ],
             [
                 '/* testReadonlyConstructorPropertyPromotionWithReference */',
                 'ReadOnly',
             ],
             [
                 '/* testReadonlyPropertyInAnonymousClass */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeUnqualified */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeFullyQualified */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypePartiallyQualified */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeRelativeName */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeMultipleSets */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeWithArray */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyDNFTypeWithSpacesAndComments */',
-                'readonly',
             ],
             [
                 '/* testReadonlyConstructorPropertyPromotionWithDNF */',
-                'readonly',
             ],
             [
                 '/* testReadonlyConstructorPropertyPromotionWithDNFAndReference */',
-                'readonly',
             ],
             [
                 '/* testParseErrorLiveCoding */',
-                'readonly',
             ],
         ];
 
@@ -196,14 +164,15 @@ public static function dataReadonly()
      * Test that "readonly" when not used as the keyword is still tokenized as `T_STRING`.
      *
      * @param string $testMarker  The comment which prefaces the target token in the test file.
-     * @param string $testContent The token content to look for.
+     * @param string $testContent Optional. The token content to look for.
+     *                            Defaults to lowercase "readonly".
      *
      * @dataProvider dataNotReadonly
      * @covers       PHP_CodeSniffer\Tokenizers\PHP::processAdditional
      *
      * @return void
      */
-    public function testNotReadonly($testMarker, $testContent)
+    public function testNotReadonly($testMarker, $testContent='readonly')
     {
         $tokens = self::$phpcsFile->getTokens();
 
@@ -230,23 +199,18 @@ public static function dataNotReadonly()
             ],
             [
                 '/* testReadonlyUsedAsMethodName */',
-                'readonly',
             ],
             [
                 '/* testReadonlyUsedAsPropertyName */',
-                'readonly',
             ],
             [
                 '/* testReadonlyPropertyInTernaryOperator */',
-                'readonly',
             ],
             [
                 '/* testReadonlyUsedAsFunctionName */',
-                'readonly',
             ],
             [
                 '/* testReadonlyUsedAsFunctionNameWithReturnByRef */',
-                'readonly',
             ],
             [
                 '/* testReadonlyUsedAsNamespaceName */',
@@ -258,39 +222,33 @@ public static function dataNotReadonly()
             ],
             [
                 '/* testReadonlyAsFunctionCall */',
-                'readonly',
             ],
             [
                 '/* testReadonlyAsNamespacedFunctionCall */',
-                'readonly',
             ],
             [
                 '/* testReadonlyAsNamespaceRelativeFunctionCall */',
                 'ReadOnly',
             ],
             [
                 '/* testReadonlyAsMethodCall */',
-                'readonly',
             ],
             [
                 '/* testReadonlyAsNullsafeMethodCall */',
                 'readOnly',
             ],
             [
                 '/* testReadonlyAsStaticMethodCallWithSpace */',
-                'readonly',
             ],
             [
                 '/* testClassConstantFetchWithReadonlyAsConstantName */',
                 'READONLY',
             ],
             [
                 '/* testReadonlyUsedAsFunctionCallWithSpaceBetweenKeywordAndParens */',
-                'readonly',
             ],
             [
                 '/* testReadonlyUsedAsMethodNameWithDNFParam */',
-                'readonly',
             ],
         ];