Squiz/ClosingDeclarationComment: improve test coverage

This commit improve the test coverage for the
Squiz.Commenting.ClosingDeclarationComment sniff by adding the following
tests:

- Function without a closing comment
- Misplaced closing comment with indentation
- Misplaced closing comment with multiple newlines
- Class missing a opening or closing bracket

It also documents via tests that anonymous classes and arrow functions
do not require a closing comment.

Author: rodrigoprimo

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.1.inc

@@ -84,3 +84,35 @@ enum MissingClosingComment {
 
 enum HasClosingComment {
 }//end enum
+
+function misplacedClosingCommentWhitespace() {
+}       //end misplacedClosingCommentWhitespace()
+
+function misplacedClosingCommentMultipleNewlines() {
+}
+
+
+//end misplacedClosingCommentMultipleNewlines()
+
+function missingClosingComment() {
+}
+
+function commentHasMoreIndentationThanFunction() {
+}
+        //end commentHasMoreIndentationThanFunction()
+
+class Foo {
+    function commentHasLessIndentationThanFunction() {
+    }
+  //end commentHasLessIndentationThanFunction()
+
+    function misplacedClosingCommentWithIndentation() {
+    }
+    //end misplacedClosingCommentWithIndentation()
+}//end class
+
+// Anonymous classes don't need end comments.
+$anon = new class {};
+
+// Arrow functions don't need end comments.
+$arrow = fn($a) => $a;

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.1.inc.fixed

@@ -83,3 +83,29 @@ enum MissingClosingComment {
 
 enum HasClosingComment {
 }//end enum
+
+function misplacedClosingCommentWhitespace() {
+}//end misplacedClosingCommentWhitespace()
+
+function misplacedClosingCommentMultipleNewlines() {
+}//end misplacedClosingCommentMultipleNewlines()
+
+function missingClosingComment() {
+}//end missingClosingComment()
+
+function commentHasMoreIndentationThanFunction() {
+}//end commentHasMoreIndentationThanFunction()
+
+class Foo {
+    function commentHasLessIndentationThanFunction() {
+    }//end commentHasLessIndentationThanFunction()
+
+    function misplacedClosingCommentWithIndentation() {
+    }//end misplacedClosingCommentWithIndentation()
+}//end class
+
+// Anonymous classes don't need end comments.
+$anon = new class {};
+
+// Arrow functions don't need end comments.
+$arrow = fn($a) => $a;

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.2.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing opening bracket).
+// This should be the only test in this file.
+// Testing that the sniff is triggered.
+
+class MissingOpeningBracket

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.3.inc

@@ -0,0 +1,7 @@
+<?php
+
+// Intentional parse error (missing closing bracket).
+// This should be the only test in this file.
+// Testing that the sniff is triggered.
+
+class MissingClosingBracket {

src/Standards/Squiz/Tests/Commenting/ClosingDeclarationCommentUnitTest.php

@@ -35,15 +35,21 @@ public function getErrorList($testFile='')
         switch ($testFile) {
         case 'ClosingDeclarationCommentUnitTest.1.inc':
             return [
-                13 => 1,
-                17 => 1,
-                31 => 1,
-                41 => 1,
-                59 => 1,
-                63 => 1,
-                67 => 1,
-                79 => 1,
-                83 => 1,
+                13  => 1,
+                17  => 1,
+                31  => 1,
+                41  => 1,
+                59  => 1,
+                63  => 1,
+                67  => 1,
+                79  => 1,
+                83  => 1,
+                89  => 1,
+                92  => 1,
+                98  => 1,
+                101 => 1,
+                106 => 1,
+                110 => 1,
             ];
 
         default:
@@ -69,6 +75,10 @@ public function getWarningList($testFile='')
         case 'ClosingDeclarationCommentUnitTest.1.inc':
             return [71 => 1];
 
+        case 'ClosingDeclarationCommentUnitTest.2.inc':
+        case 'ClosingDeclarationCommentUnitTest.3.inc':
+            return [7 => 1];
+
         default:
             return [];
         }