Generic/EmptyPHPStatement: add tests for the short open tag

Author: rodrigoprimo

src/Standards/Generic/Tests/CodeAnalysis/EmptyPHPStatementUnitTest.2.inc

@@ -0,0 +1,27 @@
+<!-- Tests with short open tag. -->
+
+<input name="<? ; something_else(); ?>" />
+<input name="<? something_else(); ; ?>" />
+
+/*
+ * Test empty statement: no code between PHP open and close tag.
+ */
+<input name="<? something_else() ?>" /> <!-- OK. -->
+<input name="<? something_else(); ?>" /> <!-- OK. -->
+<input name="<? /* comment */ ?>" /> <!-- OK. -->
+
+<input name="<? ?>" /> <!-- Bad. -->
+
+<input name="<?
+
+
+?>" /> <!-- Bad. -->
+
+<!--
+/*
+ * Test detecting & fixing a combination of the two checks.
+ */
+-->
+<? ; ?>
+
+<input name="<? ; ?>" /> <!-- Bad. -->

src/Standards/Generic/Tests/CodeAnalysis/EmptyPHPStatementUnitTest.2.inc.fixed

@@ -0,0 +1,23 @@
+<!-- Tests with short open tag. -->
+
+<input name="<?something_else(); ?>" />
+<input name="<? something_else(); ?>" />
+
+/*
+ * Test empty statement: no code between PHP open and close tag.
+ */
+<input name="<? something_else() ?>" /> <!-- OK. -->
+<input name="<? something_else(); ?>" /> <!-- OK. -->
+<input name="<? /* comment */ ?>" /> <!-- OK. -->
+
+<input name="" /> <!-- Bad. -->
+
+<input name="" /> <!-- Bad. -->
+
+<!--
+/*
+ * Test detecting & fixing a combination of the two checks.
+ */
+-->
+
+<input name="" /> <!-- Bad. -->

src/Standards/Generic/Tests/CodeAnalysis/EmptyPHPStatementUnitTest.php

@@ -20,6 +20,27 @@ final class EmptyPHPStatementUnitTest extends AbstractSniffUnitTest
 {
 
 
+    /**
+     * Get a list of all test files to check.
+     *
+     * @param string $testFileBase The base path that the unit tests files will have.
+     *
+     * @return string[]
+     */
+    protected function getTestFiles($testFileBase)
+    {
+        $testFiles = [$testFileBase.'1.inc'];
+
+        $option = (bool) ini_get('short_open_tag');
+        if ($option === true) {
+            $testFiles[] = $testFileBase.'2.inc';
+        }
+
+        return $testFiles;
+
+    }//end getTestFiles()
+
+
     /**
      * Returns the lines where errors should occur.
      *
@@ -70,6 +91,15 @@ public function getWarningList($testFile='')
                 72 => 1,
                 80 => 1,
             ];
+        case 'EmptyPHPStatementUnitTest.2.inc':
+            return [
+                3  => 1,
+                4  => 1,
+                13 => 1,
+                15 => 1,
+                25 => 1,
+                27 => 1,
+            ];
         default:
             return [];
         }//end switch