Squiz/FunctionComment: specify more specific error code for missing type

Author: fredden

src/Standards/Squiz/Sniffs/Commenting/FunctionCommentSniff.php

@@ -366,6 +366,9 @@ protected function processParams(File $phpcsFile, $stackPtr, $commentStart)
                         $phpcsFile->addError($error, $tag, 'MissingParamComment');
                         $commentLines[] = ['comment' => ''];
                     }//end if
+                } else if ($tokens[($tag + 2)]['content'][0] === '$') {
+                    $error = 'Missing parameter type';
+                    $phpcsFile->addError($error, $tag, 'MissingParamType');
                 } else {
                     $error = 'Missing parameter name';
                     $phpcsFile->addError($error, $tag, 'MissingParamName');

src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.inc

@@ -1134,3 +1134,27 @@ public function variableOrderMismatch($bar, $baz, $foo) {
  * @return never
  */
 function foo() {}
+
+/**
+ * @param $noTypeNoComment
+ * @return void
+ */
+function paramVariation1($noTypeNoComment): void {}
+
+/**
+ * @param $noTypeWithComment This parameter has no type specified.
+ * @return void
+ */
+function paramVariation2($noTypeWithComment): void {}
+
+/**
+ * @param integer $hasTypeNoComment
+ * @return void
+ */
+function paramVariation3($hasTypeNoComment): void {}
+
+/**
+ * @param integer $hasTypehasComment This parameter has type.
+ * @return void
+ */
+function paramVariation4($hasTypehasComment): void {}

src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.inc.fixed

@@ -1134,3 +1134,27 @@ public function variableOrderMismatch($bar, $baz, $foo) {
  * @return never
  */
 function foo() {}
+
+/**
+ * @param $noTypeNoComment
+ * @return void
+ */
+function paramVariation1($noTypeNoComment): void {}
+
+/**
+ * @param $noTypeWithComment This parameter has no type specified.
+ * @return void
+ */
+function paramVariation2($noTypeWithComment): void {}
+
+/**
+ * @param integer $hasTypeNoComment
+ * @return void
+ */
+function paramVariation3($hasTypeNoComment): void {}
+
+/**
+ * @param integer $hasTypehasComment This parameter has type.
+ * @return void
+ */
+function paramVariation4($hasTypehasComment): void {}

src/Standards/Squiz/Tests/Commenting/FunctionCommentUnitTest.php

@@ -137,6 +137,13 @@ public function getErrorList()
             1123 => 1,
             1124 => 1,
             1125 => 1,
+            1138 => 1,
+            1139 => 1,
+            1142 => 1,
+            1144 => 1,
+            1145 => 1,
+            1148 => 1,
+            1151 => 1,
         ];
 
         // Scalar type hints only work from PHP 7 onwards.
@@ -156,6 +163,8 @@ public function getErrorList()
             $errors[1089] = 3;
             $errors[1107] = 8;
             $errors[1129] = 3;
+            $errors[1154] = 1;
+            $errors[1160] = 1;
         } else {
             $errors[729] = 4;
             $errors[740] = 2;