Squiz/EmbeddedPhp: bug fix - open tag intended indent calculation

Basically, this is the same bug as fixed in a previous commit for the intended close tag indent calculation.
If the first token on the line before the open tag would be a subsequent line for a star-slash comment, the indentation would not be calculated correctly, but would always be set to `0`, even when there was indentation.

Fixed now, includes test.

Author: jrfnl

src/Standards/Squiz/Sniffs/PHP/EmbeddedPhpSniff.php

@@ -200,11 +200,19 @@ private function validateMultilineEmbeddedPhp($phpcsFile, $stackPtr, $closingTag
             }
         } else {
             // Find the first token on the first non-empty line we find.
-            for ($first = ($stackPtr - 1); $first > 0; $first--) {
+            for ($first = ($lastContentBeforeBlock - 1); $first > 0; $first--) {
                 if ($tokens[$first]['line'] === $tokens[$stackPtr]['line']) {
                     continue;
                 } else if (trim($tokens[$first]['content']) !== '') {
                     $first = $phpcsFile->findFirstOnLine([], $first, true);
+                    if ($tokens[$first]['code'] === T_COMMENT
+                        && $tokens[$first]['content'] !== ltrim($tokens[$first]['content'])
+                    ) {
+                        // This is a subsequent line in a star-slash comment containing leading indent.
+                        // We'll need the first line of the comment to correctly determine the indent.
+                        continue;
+                    }
+
                     break;
                 }
             }

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.1.inc

@@ -240,6 +240,31 @@ Safeguard correct close tag indent calculation.
        This means the calculated indent would be 0 unless we
        walk to the first line in the comment. */ ?>
 
+<!--
+Safeguard correct open tag indent calculation when the previous non-empty line contains a comment.
+-->
+    <?php
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */ ?>
+<?php
+echo 'the PHP tag is correctly indented as an indent less than the previous code indent is accepted';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */ ?>
+    <?php
+    echo 'the PHP tag is correctly indented';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */ ?>
+        <?php
+        echo 'the PHP tag is correctly indented as a diff of 4 is accepted';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */ ?>
+                <?php
+                echo 'the PHP tag is incorrectly indented as the indent is more than 4 different from the indent of the previous code';
+    ?>
+
 <?php
 // This test case file MUST always end with an unclosed long open PHP tag (with this comment) to prevent
 // the tests running into the "last PHP closing tag excepted" condition breaking tests.

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.1.inc.fixed

@@ -248,6 +248,35 @@ Safeguard correct close tag indent calculation.
        walk to the first line in the comment. */
     ?>
 
+<!--
+Safeguard correct open tag indent calculation when the previous non-empty line contains a comment.
+-->
+    <?php
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */
+    ?>
+<?php
+echo 'the PHP tag is correctly indented as an indent less than the previous code indent is accepted';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */
+    ?>
+    <?php
+    echo 'the PHP tag is correctly indented';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */
+    ?>
+        <?php
+        echo 'the PHP tag is correctly indented as a diff of 4 is accepted';
+
+    /* Subsequent lines of inline slash-star comments
+       contain the indent in the comment token. */
+    ?>
+        <?php
+        echo 'the PHP tag is incorrectly indented as the indent is more than 4 different from the indent of the previous code';
+    ?>
+
 <?php
 // This test case file MUST always end with an unclosed long open PHP tag (with this comment) to prevent
 // the tests running into the "last PHP closing tag excepted" condition breaking tests.

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.php

@@ -95,6 +95,11 @@ public function getErrorList($testFile='')
                 228 => 1,
                 235 => 1,
                 241 => 1,
+                248 => 1,
+                253 => 1,
+                258 => 1,
+                263 => 1,
+                264 => 1,
             ];
 
         case 'EmbeddedPhpUnitTest.2.inc':