Squiz/VariableComment: make errorcode for "TagNotAllowed" warning modular

As things are, the `VariableComment` sniff only allows `@see` tags and `@var` tags in property docblocks.

This practice feels dated to me, as commonly used tags, such as `@link`, `@deprecated` etc are not allowed.

This commit replaces the generic `TagNotAllowed` error code in the sniff with a more modular `[TagName]TagNotAllowed` error code.

This allows for rulesets to selectively ignore the `TagNotAllowed` error code for specific tags the ruleset maintainer wants to allow for the code base under scan.

Includes tests.

Author: jrfnl

src/Standards/Squiz/Sniffs/Commenting/VariableCommentSniff.php

@@ -111,7 +111,8 @@ public function processMemberVar(File $phpcsFile, $stackPtr)
             } else {
                 $error = '%s tag is not allowed in member variable comment';
                 $data  = [$tokens[$tag]['content']];
-                $phpcsFile->addWarning($error, $tag, 'TagNotAllowed', $data);
+                $code  = ucwords(ltrim($tokens[$tag]['content'], '@')).'TagNotAllowed';
+                $phpcsFile->addWarning($error, $tag, $code, $data);
             }//end if
         }//end foreach
 

src/Standards/Squiz/Tests/Commenting/VariableCommentUnitTest.inc

@@ -476,3 +476,26 @@ class PHP84FinalProperties {
      */
     final int $hasDocblock;
 }
+
+// phpcs:disable Squiz.Commenting.VariableComment.SinceTagNotAllowed
+// phpcs:disable Squiz.Commenting.VariableComment.DeprecatedTagNotAllowed
+class AllowMoreForSelectivelyIgnoringDisallowedTags {
+    /**
+     * @var string
+     *
+     * @since      3.1
+     * @deprecated 10.5
+     */
+    public string $propertyWithExtraTags;
+
+    /**
+     * @var string
+     *
+     * @link       https://example.org/some-link
+     * @api
+     * @param string This tag is not allowed.
+     */
+    public $theAboveExtraTagsAreStillNotAllowed;
+}
+
+// phpcs:enable Squiz.Commenting.VariableComment

src/Standards/Squiz/Tests/Commenting/VariableCommentUnitTest.inc.fixed

@@ -476,3 +476,26 @@ class PHP84FinalProperties {
      */
     final int $hasDocblock;
 }
+
+// phpcs:disable Squiz.Commenting.VariableComment.SinceTagNotAllowed
+// phpcs:disable Squiz.Commenting.VariableComment.DeprecatedTagNotAllowed
+class AllowMoreForSelectivelyIgnoringDisallowedTags {
+    /**
+     * @var string
+     *
+     * @since      3.1
+     * @deprecated 10.5
+     */
+    public string $propertyWithExtraTags;
+
+    /**
+     * @var string
+     *
+     * @link       https://example.org/some-link
+     * @api
+     * @param string This tag is not allowed.
+     */
+    public $theAboveExtraTagsAreStillNotAllowed;
+}
+
+// phpcs:enable Squiz.Commenting.VariableComment

src/Standards/Squiz/Tests/Commenting/VariableCommentUnitTest.php

@@ -81,7 +81,12 @@ public function getErrorList()
      */
     public function getWarningList()
     {
-        return [93 => 1];
+        return [
+            93  => 1,
+            494 => 1,
+            495 => 1,
+            496 => 1,
+        ];
 
     }//end getWarningList()