Squiz/EmbeddedPhp: make test cases more descriptive

... to allow for easier debugging.

Author: jrfnl

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.inc

@@ -15,30 +15,30 @@
     <?php
     echo $moreBody;
     ?>
-    <?php  echo 'hi'; ?>
-    <?php  echo 'hi';   ?>
-    <?php echo 'hi;' ?>
-    <?php echo 'hi'; echo 'hi;'; ?>
-    <?php  echo 'hi'; echo 'hi;';   ?>
+    <?php  echo 'one'; ?>
+    <?php  echo 'two';   ?>
+    <?php echo 'three;' ?>
+    <?php echo 'fourA'; echo 'fourB;'; ?>
+    <?php  echo 'fiveA'; echo 'fiveB;';   ?>
 
     <?php
     ?>
     <?php ?>
 
     <?php
 
-        echo $moreBody;
+        echo $start - $indent + $end;
 
     ?>
     <?php
 
-    echo $moreBody;
+    echo $blankLines;
 
         ?>
 
     <?php
-    echo $moreBody; ?>
-    <?php echo $moreBody;
+    echo $closerNeedsOwnLine; ?>
+    <?php echo $openerNeedsOwnLine;
     ?>
 
             <?php
@@ -108,12 +108,12 @@ function foo()
 <?php if ($foo) { ?>
 <?php } ?>
 
-<?php echo 'oops'; // Something. ?>
-<?php echo 'oops'; // Something.      ?>
-<?php echo 'oops'; // Something.?>
+<?php echo 'okay'; // Something. ?>
+<?php echo 'too much space before close'; // Something.      ?>
+<?php echo 'no space before close'; // Something.?>
 
-<?php /* translators: My sites label */ ?>
-<?php /* translators: My sites label */?>
-<?php /* translators: My sites label */      ?>
+<?php /* translators: okay */ ?>
+<?php /* translators: no space before close */?>
+<?php /* translators: too much space before close */      ?>
 
-<?php echo 'oops'; // phpcs:ignore Standard.Category.Sniff -- reason. ?>
+<?php echo 'okay'; // phpcs:ignore Standard.Category.Sniff -- reason. ?>

src/Standards/Squiz/Tests/PHP/EmbeddedPhpUnitTest.inc.fixed

@@ -15,25 +15,25 @@
     <?php
     echo $moreBody;
     ?>
-    <?php echo 'hi'; ?>
-    <?php echo 'hi'; ?>
-    <?php echo 'hi;'; ?>
-    <?php echo 'hi'; echo 'hi;'; ?>
-    <?php echo 'hi'; echo 'hi;'; ?>
+    <?php echo 'one'; ?>
+    <?php echo 'two'; ?>
+    <?php echo 'three;'; ?>
+    <?php echo 'fourA'; echo 'fourB;'; ?>
+    <?php echo 'fiveA'; echo 'fiveB;'; ?>
 
 
     <?php
-    echo $moreBody;
+    echo $start - $indent + $end;
     ?>
     <?php
-    echo $moreBody;
+    echo $blankLines;
         ?>
 
     <?php
-    echo $moreBody; 
+    echo $closerNeedsOwnLine; 
     ?>
     <?php 
-    echo $moreBody;
+    echo $openerNeedsOwnLine;
     ?>
 
         <?php
@@ -108,12 +108,12 @@ function foo()
 <?php if ($foo) { ?>
 <?php } ?>
 
-<?php echo 'oops'; // Something. ?>
-<?php echo 'oops'; // Something. ?>
-<?php echo 'oops'; // Something. ?>
+<?php echo 'okay'; // Something. ?>
+<?php echo 'too much space before close'; // Something. ?>
+<?php echo 'no space before close'; // Something. ?>
 
-<?php /* translators: My sites label */ ?>
-<?php /* translators: My sites label */ ?>
-<?php /* translators: My sites label */ ?>
+<?php /* translators: okay */ ?>
+<?php /* translators: no space before close */ ?>
+<?php /* translators: too much space before close */ ?>
 
-<?php echo 'oops'; // phpcs:ignore Standard.Category.Sniff -- reason. ?>
+<?php echo 'okay'; // phpcs:ignore Standard.Category.Sniff -- reason. ?>