Generic/UpperCaseConstantName: minor improvement to the error message and metrics

This commit implements a minor improvement to the error message and
metric recording when handling calls to `define()`. Now the line of
the error or the line recorded in the metric will be the line of the
constant name. Before it was the line of the T_DEFINE token.

Author: rodrigoprimo

src/Standards/Generic/Sniffs/NamingConventions/UpperCaseConstantNameSniff.php

@@ -133,19 +133,19 @@ public function process(File $phpcsFile, $stackPtr)
 
         if (strtoupper($constName) !== $constName) {
             if (strtolower($constName) === $constName) {
-                $phpcsFile->recordMetric($stackPtr, 'Constant name case', 'lower');
+                $phpcsFile->recordMetric($constPtr, 'Constant name case', 'lower');
             } else {
-                $phpcsFile->recordMetric($stackPtr, 'Constant name case', 'mixed');
+                $phpcsFile->recordMetric($constPtr, 'Constant name case', 'mixed');
             }
 
             $error = 'Constants must be uppercase; expected %s but found %s';
             $data  = [
                 $prefix.strtoupper($constName),
                 $prefix.$constName,
             ];
-            $phpcsFile->addError($error, $stackPtr, 'ConstantNotUpperCase', $data);
+            $phpcsFile->addError($error, $constPtr, 'ConstantNotUpperCase', $data);
         } else {
-            $phpcsFile->recordMetric($stackPtr, 'Constant name case', 'upper');
+            $phpcsFile->recordMetric($constPtr, 'Constant name case', 'upper');
         }
 
     }//end process()

src/Standards/Generic/Tests/NamingConventions/UpperCaseConstantNameUnitTest.php

@@ -41,7 +41,7 @@ public function getErrorList()
             40 => 1,
             41 => 1,
             45 => 1,
-            47 => 1,
+            51 => 1,
         ];
 
     }//end getErrorList()