PHP 8.4 | File::getMemberProperties(): add support for asymmetric visibility

Implements the suggested support per #851 (comment) with one difference: the `set_scope` key will always be available, but will be `false` if no set scope is specified. This is more in line with the other keys in the return array.

Includes tests.
Includes updated test expectation for the PSR2/PropertyDeclarationSniff. Mind: this sniff still needs further updates!

Follow up on 871
Partial fix for 851

Related to 734

Author: jrfnl

src/Files/File.php

@@ -1827,6 +1827,9 @@ public function getMethodProperties($stackPtr)
      *   array(
      *    'scope'           => string,        // Public, private, or protected.
      *    'scope_specified' => boolean,       // TRUE if the scope was explicitly specified.
+     *    'set_scope'       => string|false,  // Scope for asymmetric visibility.
+     *                                        // Either public, private, or protected or
+     *                                        // FALSE if no set scope is specified.
      *    'is_static'       => boolean,       // TRUE if the static keyword was found.
      *    'is_readonly'     => boolean,       // TRUE if the readonly keyword was found.
      *    'is_final'        => boolean,       // TRUE if the final keyword was found.
@@ -1896,19 +1899,18 @@ public function getMemberProperties($stackPtr)
         }
 
         $valid = [
-            T_PUBLIC    => T_PUBLIC,
-            T_PRIVATE   => T_PRIVATE,
-            T_PROTECTED => T_PROTECTED,
-            T_STATIC    => T_STATIC,
-            T_VAR       => T_VAR,
-            T_READONLY  => T_READONLY,
-            T_FINAL     => T_FINAL,
+            T_STATIC   => T_STATIC,
+            T_VAR      => T_VAR,
+            T_READONLY => T_READONLY,
+            T_FINAL    => T_FINAL,
         ];
 
+        $valid += Tokens::$scopeModifiers;
         $valid += Tokens::$emptyTokens;
 
         $scope          = 'public';
         $scopeSpecified = false;
+        $setScope       = false;
         $isStatic       = false;
         $isReadonly     = false;
         $isFinal        = false;
@@ -1941,6 +1943,15 @@ public function getMemberProperties($stackPtr)
                 $scope          = 'protected';
                 $scopeSpecified = true;
                 break;
+            case T_PUBLIC_SET:
+                $setScope = 'public';
+                break;
+            case T_PROTECTED_SET:
+                $setScope = 'protected';
+                break;
+            case T_PRIVATE_SET:
+                $setScope = 'private';
+                break;
             case T_STATIC:
                 $isStatic = true;
                 break;
@@ -2004,6 +2015,7 @@ public function getMemberProperties($stackPtr)
         return [
             'scope'           => $scope,
             'scope_specified' => $scopeSpecified,
+            'set_scope'       => $setScope,
             'is_static'       => $isStatic,
             'is_readonly'     => $isReadonly,
             'is_final'        => $isFinal,

src/Standards/PSR2/Tests/Classes/PropertyDeclarationUnitTest.php

@@ -64,8 +64,6 @@ public function getErrorList()
             101 => 2,
             105 => 1,
             107 => 1,
-            109 => 1,
-            111 => 1,
         ];
 
     }//end getErrorList()

tests/Core/Files/File/GetMemberPropertiesTest.inc

@@ -375,3 +375,29 @@ class WithFinalProperties {
     /* testPHP84FinalComplexTypedProp */
     final public (Foo&\Bar)|bool $val9;
 }
+
+class AsymVisibility {
+    /* testPHP84AsymPublicSetProperty */
+    public(set) mixed $prop1;
+    /* testPHP84AsymPublicPublicSetProperty */
+    public public(set) (A&B)|null $prop2;
+    /* testPHP84AsymPublicSetPublicProperty */
+    public(set) public bool $prop3;
+
+    /* testPHP84AsymProtectedSetProperty */
+    protected(set) readonly mixed $prop4;
+    /* testPHP84AsymPublicProtectedSetProperty */
+    public protected(set) string $prop5;
+    /* testPHP84AsymProtectedSetPublicProperty */
+    protected(set) public ?float $prop6;
+
+    /* testPHP84AsymPrivateSetProperty */
+    private(set) string|int $prop7;
+    /* testPHP84AsymProtectedPrivateSetProperty */
+    final protected private(set) $prop8;
+    /* testPHP84AsymPrivateSetPublicProperty */
+    private(set) public mixed $prop9;
+
+    /* testPHP84IllegalAsymPublicProtectedSetStaticProperty */
+    public protected(set) static mixed $prop10;
+}