feat(target-directory): Do not require empty target directory

Author: anibalsanchez

app/Support/Validator.php

@@ -13,6 +13,7 @@
 namespace App\Support;
 
 use Exception;
+use Github\Api\CurrentUser;
 use Github\Client as GithubClient;
 use Illuminate\Support\Facades\File;
 
@@ -38,15 +39,7 @@ public function isValidSourceDirectory(string $param): bool
     public function isValidTargetDirectory(string $param): bool
     {
         if (File::exists($param)) {
-            if (!File::isDirectory($param)) {
-                return false;
-            }
-
-            if (!empty(File::allFiles($param))) {
-                return false;
-            }
-
-            return true;
+            return File::isDirectory($param);
         }
 
         mkdir($param, 0700, true);
@@ -86,6 +79,8 @@ public function isValidGithubAccessToken(string $githubAccessToken): bool
         try {
             $githubClient = new GithubClient();
             $githubClient->authenticate($githubAccessToken, null, GithubClient::AUTH_ACCESS_TOKEN);
+
+            /** @var $user CurrentUser */
             $user = $githubClient->api('me');
             $me = $user->show();
 

tests/Support/ValidatorTest.php

@@ -35,12 +35,11 @@ public function testIsValidTargetDirectory()
         $validator = new Validator();
         $targetDirectory = env('TARGET_DIRECTORY');
         $this->assertTrue(File::exists($targetDirectory));
-        $this->assertEmpty(File::allFiles($targetDirectory));
 
         $this->assertTrue($validator->isValidTargetDirectory($targetDirectory));
 
         touch($targetDirectory.'/test');
-        $this->assertFalse($validator->isValidTargetDirectory($targetDirectory));
+        $this->assertTrue($validator->isValidTargetDirectory($targetDirectory));
         unlink($targetDirectory.'/test');
 
         rmdir($targetDirectory);