Skip to content

Drop redundant await in GovernorNoncesKeyed helper #6064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amxx merged 2 commits into from
Nov 10, 2025
Merged

Drop redundant await in GovernorNoncesKeyed helper #6064

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
afd0735
Update GovernorNoncesKeyed.test.js
Doryu001 Nov 5, 2025
509b91d
Refactor getNonce function for cleaner syntax
Amxx Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/governance/extensions/GovernorNoncesKeyed.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ describe('GovernorNoncesKeyed', function () {
const maskedProposalId = BigInt(this.helper.id) & (2n ** 192n - 1n);

this.getNonce = async address => {
return await (nonceType === 'default'
return nonceType === 'default'
? this.mock.nonces(address)
: this.mock['nonces(address,uint192)'](address, maskedProposalId));
: this.mock['nonces(address,uint192)'](address, maskedProposalId);
};
});

Expand Down
Loading