Make ESLint config compatible with Node 18/20

[prestoalvarez]

• What: Replace import.meta.dirname with fileURLToPath(import.meta.url) to resolve .gitignore path in eslint.config.mjs.
• Why: import.meta.dirname is Node 22+ only; it breaks linting on LTS Node 18/20 and in CI.

[changeset-bot]

⚠️ No Changeset found

Latest commit: fd434af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The ESLint configuration was updated to establish a __dirname constant using Node.js utilities. The change imports fileURLToPath from the node:url module and derives the directory path from import.meta.url. This newly defined constant replaces the previous import.meta.dirname reference within the includeIgnoreFile function call, modifying how the .gitignore file path is resolved. The modification is internal to path resolution logic and does not affect any exported APIs or data structures.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title succinctly summarizes the core change of making the ESLint configuration compatible with Node 18/20 by explicitly targeting that compatibility update and is directly related to the modifications in eslint.config.mjs.
Description Check	✅ Passed	The description clearly explains what change was made (replacing import.meta.dirname with fileURLToPath(import.meta.url)) and why (to support Node 18/20 and avoid breaks in CI), directly reflecting the code modifications in eslint.config.mjs.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1cf1377 and fd434af.

📒 Files selected for processing (1)

• eslint.config.mjs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)

• GitHub Check: tests
• GitHub Check: coverage
• GitHub Check: slither
• GitHub Check: tests-upgradeable
• GitHub Check: tests-foundry
• GitHub Check: halmos

🔇 Additional comments (2)

eslint.config.mjs (2)

6-8: LGTM! Correct implementation for Node 18/20 compatibility.

The __dirname setup correctly uses the standard ES module pattern. The fileURLToPath import and path.dirname() combination is the idiomatic way to obtain the directory path in ES modules for Node versions that don't support import.meta.dirname.

---

28-28: LGTM! Correct usage of the new __dirname constant.

The .gitignore path resolution now uses the newly defined __dirname, which ensures compatibility with Node 18/20 LTS versions while maintaining the same functionality.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ernestognw]

Hi @prestoalvarez, the repository is using Node 22 (see) so I'm wondering why is this change needed. Is there any issue while using the repository in another project as a submodule? I can't think of another situation in which preserving compatibility with Node 18/20 makes sense.

[ernestognw]

Let's not block this PR. If it works and we're using Node 22 it would only make it irrelevant for the CI.

Merging