Merge pull request #159 from ekohl/drop-pending

Revert "Mark some failing 8.3 Windows tests as pending"

Author: bastelfreak

spec/integration/directory_environments_spec.rb

@@ -30,7 +30,6 @@
 
     it 'given an 8.3 style path on Windows, will config print an expanded path',
       :if => Puppet::Util::Platform.windows? do
-      pending("GH runners seem to have disabled 8.3 support")
 
       # ensure an 8.3 style path is set for environmentpath
       shortened = Puppet::Util::Windows::File.get_short_pathname(Puppet[:environmentpath])

spec/integration/node/environment_spec.rb

@@ -38,7 +38,6 @@ def a_module_in(name, dir)
 
   it "should expand 8.3 paths on Windows when creating an environment",
     :if => Puppet::Util::Platform.windows? do
-    pending("GH runners seem to have disabled 8.3 support")
 
     # asking for short names only works on paths that exist
     base = Puppet::Util::Windows::File.get_short_pathname(tmpdir("env_modules"))

spec/unit/file_system_spec.rb

@@ -908,8 +908,6 @@ def increment_counter_in_multiple_processes(file, num_procs, options)
         end
 
         it 'should expand a shortened path completely, unlike Ruby File.expand_path' do
-          pending("GH runners seem to have disabled 8.3 support")
-
           tmp_long_dir = tmpdir('super-long-thing-that-Windows-shortens')
           short_path = Puppet::Util::Windows::File.get_short_pathname(tmp_long_dir)
 

spec/unit/util/autoload_spec.rb

@@ -203,8 +203,6 @@ def with_libdir(libdir)
     end
 
     it "autoloads from a directory whose ancestor is Windows 8.3", if: Puppet::Util::Platform.windows? do
-      pending("GH runners seem to have disabled 8.3 support")
-
       # File.expand_path will expand ~ in the last directory component only(!)
       # so create an ancestor directory with a long path
       dir = File.join(tmpdir('longpath'), 'short')